Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
// phpcs:enable PSR1.Files.SideEffects

/**
* Plugins display controller.
* Actionlogs display controller.
*
* @since 4.0.0
*/
Expand Down
2 changes: 1 addition & 1 deletion administrator/components/com_fields/forms/field.xml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
name="default_value"
type="textarea"
label="COM_FIELDS_FIELD_DEFAULT_VALUE_LABEL"
filter="raw"
filter="safehtml"
/>

<field
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ protected function getListQuery()
if (stripos($search, 'id:') === 0) {
$search = (int) substr($search, 3);
$query->where($db->quoteName('a.id') . ' = :search')
->bind(':id', $search, ParameterType::INTEGER);
->bind(':search', $search, ParameterType::INTEGER);
} else {
$search = '%' . str_replace(' ', '%', trim($search)) . '%';
$query->where($db->quoteName('a.title') . ' LIKE :search')
Expand Down
2 changes: 1 addition & 1 deletion administrator/language/en-GB/install.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<extension client="administrator" type="language" method="upgrade">
<name>English (en-GB)</name>
<tag>en-GB</tag>
<version>4.4.6</version>
<version>4.4.7</version>
<creationDate>2024-07</creationDate>
<author>Joomla! Project</author>
<authorEmail>admin@joomla.org</authorEmail>
Expand Down
2 changes: 1 addition & 1 deletion administrator/language/en-GB/langmetadata.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<metafile client="administrator">
<name>English (en-GB)</name>
<version>4.4.6</version>
<version>4.4.7</version>
<creationDate>2024-07</creationDate>
<author>Joomla! Project</author>
<authorEmail>admin@joomla.org</authorEmail>
Expand Down
2 changes: 1 addition & 1 deletion administrator/manifests/files/joomla.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<authorUrl>www.joomla.org</authorUrl>
<copyright>(C) 2019 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
<version>4.4.6-rc2-dev</version>
<version>4.4.7-dev</version>
<creationDate>2024-07</creationDate>
<description>FILES_JOOMLA_XML_DESCRIPTION</description>

Expand Down
2 changes: 1 addition & 1 deletion administrator/manifests/packages/pkg_en-GB.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<extension type="package" method="upgrade">
<name>English (en-GB) Language Pack</name>
<packagename>en-GB</packagename>
<version>4.4.6.1</version>
<version>4.4.7.1</version>
<creationDate>2024-07</creationDate>
<author>Joomla! Project</author>
<authorEmail>admin@joomla.org</authorEmail>
Expand Down
2 changes: 1 addition & 1 deletion api/language/en-GB/install.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<extension client="api" type="language" method="upgrade">
<name>English (en-GB)</name>
<tag>en-GB</tag>
<version>4.4.6</version>
<version>4.4.7</version>
<creationDate>2024-07</creationDate>
<author>Joomla! Project</author>
<authorEmail>admin@joomla.org</authorEmail>
Expand Down
2 changes: 1 addition & 1 deletion api/language/en-GB/langmetadata.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<metafile client="api">
<name>English (en-GB)</name>
<version>4.4.6</version>
<version>4.4.7</version>
<creationDate>2024-07</creationDate>
<author>Joomla! Project</author>
<authorEmail>admin@joomla.org</authorEmail>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,8 @@ window.customElements.define('joomla-field-fancy-select', class extends HTMLElem

// Create and add new
this.choicesInstance.setChoices([{
value: this.newItemPrefix + event.target.value,
label: event.target.value,
value: new DOMParser().parseFromString(this.newItemPrefix + event.target.value, 'text/html').body.textContent,
label: new DOMParser().parseFromString(event.target.value, 'text/html').body.textContent,
selected: true,
customProperties: {
value: event.target.value, // Store real value, just in case
Expand Down
2 changes: 2 additions & 0 deletions components/com_wrapper/tmpl/wrapper/default.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
<field
name="url"
type="url"
validate="url"
filter="url"
label="COM_WRAPPER_FIELD_URL_LABEL"
required="true"
/>
Expand Down
2 changes: 1 addition & 1 deletion installation/language/en-GB/langmetadata.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<metafile client="installation">
<name>English (United Kingdom)</name>
<version>4.4.6</version>
<version>4.4.7</version>
<creationDate>2024-07</creationDate>
<author>Joomla! Project</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
Expand Down
2 changes: 1 addition & 1 deletion language/en-GB/install.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<extension client="site" type="language" method="upgrade">
<name>English (en-GB)</name>
<tag>en-GB</tag>
<version>4.4.6</version>
<version>4.4.7</version>
<creationDate>2024-07</creationDate>
<author>Joomla! Project</author>
<authorEmail>admin@joomla.org</authorEmail>
Expand Down
2 changes: 1 addition & 1 deletion language/en-GB/langmetadata.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<metafile client="site">
<name>English (en-GB)</name>
<version>4.4.6</version>
<version>4.4.7</version>
<creationDate>2024-07</creationDate>
<author>Joomla! Project</author>
<authorEmail>admin@joomla.org</authorEmail>
Expand Down
15 changes: 11 additions & 4 deletions libraries/src/Console/TasksListCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,22 @@ protected function doExecute(InputInterface $input, OutputInterface $output): in
$tasks = array_map(
function (\stdClass $task): array {
$enabled = $task->state === 1;
$nextExec = Factory::getDate($task->next_execution, 'UTC');
$due = $enabled && $task->taskOption && Factory::getDate('now', 'UTC') > $nextExec;
$rule = json_decode($task->execution_rules);

if ($rule->{'rule-type'} === 'manual') {
$nextRun = 'Manual';
} else {
$nextExec = Factory::getDate($task->next_execution, 'UTC');
$due = $enabled && $task->taskOption && Factory::getDate('now', 'UTC') > $nextExec;
$nextRun = $due ? 'DUE!' : $nextExec->toRFC822();
}

return [
'id' => $task->id,
'title' => $task->title,
'type' => $task->safeTypeTitle,
'state' => $task->state === 1 ? 'Enabled' : ($task->state === 0 ? 'Disabled' : 'Trashed'),
'next_execution' => $due ? 'DUE!' : $nextExec->toRFC822(),
'next_execution' => $nextRun,
];
},
$this->getTasks()
Expand All @@ -105,7 +112,7 @@ private function getTasks(): array

return $scheduler->fetchTaskRecords(
['state' => '*'],
['ordering' => 'a.title', 'select' => 'a.id, a.title, a.type, a.state, a.next_execution']
['ordering' => 'a.title', 'select' => 'a.id, a.title, a.type, a.state, a.next_execution, a.execution_rules']
);
}

Expand Down
3 changes: 3 additions & 0 deletions libraries/src/Form/Field/AccessiblemediaField.php
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,9 @@ public function setup(\SimpleXMLElement $element, $value, $group = null)
preview="$this->preview"
preview_width="$this->previewWidth"
preview_height="$this->previewHeight"
schemes="http,https,ftp,ftps,data,file"
validate="url"
relative="true"
/>

<field
Expand Down
6 changes: 4 additions & 2 deletions libraries/src/HTML/Helpers/StringHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,16 @@ public static function truncate($text, $length = 0, $noSplit = true, $allowHtml

// Check if HTML tags are allowed.
if (!$allowHtml) {
// Decode entities
$text = html_entity_decode($text, ENT_QUOTES, 'UTF-8');

// Deal with spacing issues in the input.
$text = str_replace('>', '> ', $text);
$text = str_replace(['&nbsp;', '&#160;'], ' ', $text);
$text = FrameworkStringHelper::trim(preg_replace('#\s+#mui', ' ', $text));

// Strip the tags from the input and decode entities.
// Strip tags from the input.
$text = strip_tags($text);
$text = html_entity_decode($text, ENT_QUOTES, 'UTF-8');

// Remove remaining extra spaces.
$text = str_replace('&nbsp;', ' ', $text);
Expand Down
8 changes: 4 additions & 4 deletions libraries/src/Version.php
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ final class Version
* @var integer
* @since 3.8.0
*/
public const PATCH_VERSION = 6;
public const PATCH_VERSION = 7;

/**
* Extra release version info.
Expand All @@ -66,7 +66,7 @@ final class Version
* @var string
* @since 3.8.0
*/
public const EXTRA_VERSION = 'rc2-dev';
public const EXTRA_VERSION = 'dev';

/**
* Development status.
Expand All @@ -90,15 +90,15 @@ final class Version
* @var string
* @since 3.5
*/
public const RELDATE = '4-July-2024';
public const RELDATE = '9-July-2024';

/**
* Release time.
*
* @var string
* @since 3.5
*/
public const RELTIME = '18:01';
public const RELTIME = '16:01';

/**
* Release timezone.
Expand Down
4 changes: 3 additions & 1 deletion modules/mod_wrapper/mod_wrapper.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@
<fieldset name="basic">
<field
name="url"
type="text"
type="url"
validate="url"
filter="url"
label="MOD_WRAPPER_FIELD_URL_LABEL"
required="true"
/>
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "joomla",
"version": "4.4.6",
"version": "4.4.7",
"description": "Joomla CMS",
"license": "GPL-2.0-or-later",
"repository": {
Expand Down Expand Up @@ -111,4 +111,4 @@
"stylelint-order": "^5.0.0",
"stylelint-scss": "^4.7.0"
}
}
}
16 changes: 8 additions & 8 deletions plugins/content/vote/tmpl/rating.php
Original file line number Diff line number Diff line change
Expand Up @@ -79,17 +79,17 @@
?>
<div class="content_rating" role="img" aria-label="<?php echo Text::sprintf('PLG_VOTE_STAR_RATING', $rating); ?>">
<?php if ($rcount) : ?>
<div class="visually-hidden" itemscope itemtype="https://schema.org/Product">
<span itemprop="name"><?php echo $row->title; ?></span>
<p class="visually-hidden" itemprop="aggregateRating" itemscope itemtype="https://schema.org/AggregateRating">
<?php echo Text::sprintf('PLG_VOTE_USER_RATING', '<span itemprop="ratingValue">' . $rating . '</span>', '<span itemprop="bestRating">5</span>'); ?>
<meta itemprop="ratingCount" content="<?php echo $rcount; ?>">
<meta itemprop="worstRating" content="1">
</p>
<div class="visually-hidden" itemscope itemtype="https://schema.org/Product">
<span itemprop="name"><?php echo $row->title; ?></span>
<p itemprop="aggregateRating" itemscope itemtype="https://schema.org/AggregateRating">
<?php echo Text::sprintf('PLG_VOTE_USER_RATING', '<span itemprop="ratingValue">' . $rating . '</span>', '<span itemprop="bestRating">5</span>'); ?>
<meta itemprop="ratingCount" content="<?php echo $rcount; ?>">
<meta itemprop="worstRating" content="1">
</p>
</div>
<?php if ($this->params->get('show_total_votes', 0)) : ?>
<?php echo Text::sprintf('PLG_VOTE_TOTAL_VOTES', $rcount); ?>
<?php endif; ?>
</div>
<?php endif; ?>
<ul>
<?php echo $img; ?>
Expand Down
12 changes: 7 additions & 5 deletions tests/System/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,13 @@ npm run cypress:run

You can execute single test specs, e.g. to run the installation step only.
```
npm run cypress:run --spec tests/System/integration/install/Installation.cy.js
npx cypress run --spec tests/System/integration/install/Installation.cy.js
```

You can run multiple test specs separated by commas and use patterns. For example, to execute all the tests from the
administrator, site, api and plugins specs without the installation step:
You can run multiple test specs separated by commas and use patterns.
For example, to run all tests without the installation step:
```
npm run cypress:run --spec 'tests/System/integration/{administrator,site,api,plugins}/**/*.cy.js'
npx cypress run --spec 'tests/System/integration/{administrator,site,api,plugins}/**/*.cy.js'
```

> [!NOTE]
Expand Down Expand Up @@ -293,7 +293,7 @@ sudo npm run cypress:run

If the `root` user does not have a Cypress installation, you can use the Cypress installation cache of the current user:
```
sudo CYPRESS_CACHE_FOLDER=$HOME/.cache/Cypress npm run cypress:run
CYPRESS_CACHE_FOLDER=$HOME/.cache/Cypress sudo npm run cypress:run
```


Expand All @@ -310,6 +310,8 @@ If the used SMTP server port is already in use you will see an error like:

:point_right: Configure a different, unused port in the `cypress.config.mjs` file as `smtp_port`.

:point_right: If you use `npx` instead of `npm`, you may see `Your configFile threw an error from: cypress.config.js`,
but you still need to configure `cypress.config.mjs` file.

### Timeout Error on Slow Machines

Expand Down