improve auth/change-password

muhammadmp97 · Sep 19, 2023 · a0723a4 · a0723a4
1 parent 0d685a8
commit a0723a4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/app/Actions/User/ChangePasswordAction.php b/app/Actions/User/ChangePasswordAction.php
@@ -17,7 +17,7 @@ public function execute(User $user, $data): void
         }
 
         $user->update([
-            'password' => Hash::make($data['password']),
+            'password' => Hash::make($data['new_password']),
         ]);
     }
 }
diff --git a/app/Http/Requests/ChangePasswordRequest.php b/app/Http/Requests/ChangePasswordRequest.php
@@ -15,7 +15,7 @@ public function rules(): array
     {
         return [
             'old_password' => ['required', 'string'],
-            'password' => ['required', 'string', 'min:6'],
+            'new_password' => ['required', 'string', 'min:6', 'different:old_password'],
         ];
     }
 }
diff --git a/tests/Feature/AuthControllerTest.php b/tests/Feature/AuthControllerTest.php
@@ -62,7 +62,7 @@ public function test_user_changes_password_using_old_password()
 
         $this->postJson('api/auth/change-password', [
             'old_password' => '12345678',
-            'password' => 'password',
+            'new_password' => 'password',
         ])->assertOk();
 
         $this->assertTrue(Hash::check('password', $user->password));
@@ -74,7 +74,7 @@ public function test_user_needs_old_password_for_changing_password()
 
         $this->postJson('api/auth/change-password', [
             'old_password' => '1234',
-            'password' => 'password',
+            'new_password' => 'password',
         ])->assertJsonValidationErrorFor('old_password');
     }
 }