Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup for the custom tag sub/sup fixed #152

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Conversation

pkamps
Copy link
Member

@pkamps pkamps commented May 24, 2019

he sub (subscript) and sup (superscript) tags work, but there is a UI issue.

Hitting "Ok" once adds the tag, but does not close the dialog. The dialog only closes upon clicking "Cancel."

While the dialog is open, each click of "Ok" after the first inserts the highlighted text at the beginning of the paragraph, in the sub or sup style.

Hitting "Cancel" is the only way out, which makes the necessary workflow:

Select text
Select Custom tags
Select "Sup"
Click OK
Click Cancel

Reproduce / Testing instructions

Select text
Select Custom tags
Select "Sup"
Click OK => Dialog remains open
Click OL => Duplicate text inserted at beginning of paragraph.

Tested with: Mac Chrome.

@peterkeung
Copy link
Member

This should go upstream too

@pkamps
Copy link
Member Author

pkamps commented May 28, 2019

Upstream pull request:
ezsystems#1434

@pkamps
Copy link
Member Author

pkamps commented Jun 4, 2019

Ready to get merged.

@pkamps pkamps merged commit 3a8c14b into master Jun 5, 2019
@pkamps pkamps deleted the fix_custom_tag_popup branch June 5, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants