fix(projects): fix eslint errors

mufeng889 · Sep 9, 2024 · fec80a1 · fec80a1
1 parent 084bf89
commit fec80a1
Show file tree

Hide file tree

Showing 9 changed files with 15 additions and 14 deletions.
diff --git a/build/plugins/router.ts b/build/plugins/router.ts
@@ -1,6 +1,7 @@
 import ElegantReactRouter from '@ohh-889/react-auto-route/vite';
 import type { RouteKey } from '@elegant-router/types';
 
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 interface RouteMeta extends Record<string | number, unknown> {}
 
 export function setupElegantRouter() {

diff --git a/packages/materials/src/libs/page-tab/SvgClose.tsx b/packages/materials/src/libs/page-tab/SvgClose.tsx
@@ -2,9 +2,7 @@ import type { FC, TouchEvent } from 'react';
 import React, { useState } from 'react';
 import classNames from 'classnames';
 
-interface SvgCloseProps extends React.ComponentProps<'div'> {}
-
-const SvgClose: FC<SvgCloseProps> = ({ className, onClick, ...props }) => {
+const SvgClose: FC<React.ComponentProps<'div'>> = ({ className, onClick, ...props }) => {
   const [touchStart, setTouchStart] = useState(false);
 
   // 处理触摸开始事件
@@ -15,7 +13,7 @@ const SvgClose: FC<SvgCloseProps> = ({ className, onClick, ...props }) => {
   // 处理触摸结束事件
   const handleTouchEnd = (event: TouchEvent) => {
     if (touchStart) {
-      onClick && onClick(event as any);
+      if (onClick) onClick(event as any);
     }
 
     // 重置触摸状态

diff --git a/packages/materials/src/libs/page-tab/index.tsx b/packages/materials/src/libs/page-tab/index.tsx
@@ -45,13 +45,13 @@ const PageTab: FC<PageTabProps> = ({
 
   function closeTab(event: React.MouseEvent | TouchEvent) {
     event.stopPropagation();
-    handleClose && handleClose();
+    if (handleClose) handleClose();
   }
 
   function handleMouseup(e: React.MouseEvent<HTMLDivElement>) {
     // close tab by mouse wheel button click
     if (e.button === 1) {
-      handleClose && handleClose();
+      if (handleClose) handleClose();
     }
   }
 

diff --git a/src/layouts/modules/global-breadcrumb/index.tsx b/src/layouts/modules/global-breadcrumb/index.tsx
@@ -15,7 +15,7 @@ function BreadcrumbContent({ label, icon }: { label: JSX.Element; icon: JSX.Elem
   );
 }
 
-const GlobalBreadcrumb: FC<Omit<BreadcrumbProps, 'items'>> = memo(props => {
+const GlobalBreadcrumb: FC<Omit<BreadcrumbProps, 'items'>> = props => {
   const { allMenus: menus, route } = useMixMenuContext();
 
   const routerPush = useRouterPush();
@@ -52,8 +52,8 @@ const GlobalBreadcrumb: FC<Omit<BreadcrumbProps, 'items'>> = memo(props => {
     <Breadcrumb
       {...props}
       items={items}
-    ></Breadcrumb>
+    />
   );
-});
+};
 
-export default GlobalBreadcrumb;
+export default memo(GlobalBreadcrumb);
diff --git a/src/layouts/modules/global-menu/components/FirstLevelMenu.tsx b/src/layouts/modules/global-menu/components/FirstLevelMenu.tsx
@@ -39,7 +39,7 @@ function MixMenuItem(Props: MixMenuItemProps) {
     setActiveFirstLevelMenuKey(key);
 
     if (children?.length) {
-      onClick && onClick();
+      if (onClick) onClick();
     } else {
       router.routerPushByKeyWithMetaQuery(key as RouteKey);
     }

diff --git a/src/pages/about/index.tsx b/src/pages/about/index.tsx
@@ -31,8 +31,8 @@ function transformVersionData(tuple: [string, string]): PkgVersionInfo {
 const pkgJson: PkgJson = {
   name,
   version,
-  dependencies: Object.entries(dependencies).map(item => transformVersionData(item)),
-  devDependencies: Object.entries(devDependencies).map(item => transformVersionData(item))
+  dependencies: Object.entries(dependencies).map(transformVersionData),
+  devDependencies: Object.entries(devDependencies).map(transformVersionData)
 };
 
 export function Component() {

diff --git a/src/pages/function/request/index.tsx b/src/pages/function/request/index.tsx
@@ -1,5 +1,6 @@
 import { Button, Card, Space } from 'antd';
 import { fetchCustomBackendError } from '@/service/api';
+
 export function Component() {
   const { t } = useTranslation();
   async function logout() {

diff --git a/src/pages/function/tab/index.tsx b/src/pages/function/tab/index.tsx
@@ -7,6 +7,7 @@ export function Component() {
   const { t } = useTranslation();
 
   const dispatch = useAppDispatch();
+
   function changeTabLabel(value: string) {
     dispatch(setTabLabel(value));
   }

diff --git a/src/utils/service.ts b/src/utils/service.ts
@@ -11,7 +11,7 @@ export function createServiceConfig(env: Env.ImportMeta) {
   let other = {} as Record<App.Service.OtherBaseURLKey, string>;
   try {
     other = json5.parse(VITE_OTHER_SERVICE_BASE_URL);
-  } catch (error) {
+  } catch {
     // eslint-disable-next-line no-console
     console.error('VITE_OTHER_SERVICE_BASE_URL is not a valid json5 string');
   }