Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget to toggle mute of pulseaudio default source #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lnqs
Copy link

@lnqs lnqs commented Feb 14, 2022

I created a new widget to display and toggle the mute state of the default pulseaudio source.
No idea if this is interesting for upstream as it's quite specific to the Linux desktop due to it's dependency to pulse.
Anyway, if it is I'm looking forward for feedback to get it merged :)

New widget displaying the current mute state of the default pulseaudio
source. Pressing it toggles the state.
@zMoooooritz
Copy link
Contributor

zMoooooritz commented Feb 14, 2022

Just some thoughts from my side:
This does introduce the concept of a system status dependent 'state-full' widget for one specific application i.e. exchange images according to the mute state.
In #49 such a feature (for conditional output and more) has been requested and I think this would be awesome but does require quite some changes.
In case we would have that feature we could achieve the functionality of your widget by calling local bash scripts via exec.

@lnqs
Copy link
Author

lnqs commented Feb 14, 2022

Having that feature from #49 would be really nice as it gives a lot of flexibility.
I'd prefer a implementation accessing system state (pulse in this case) natively above calling commands anyway.

Probably the best way on a longer term would be to have a thin base application and a plugin system to allow more specific widgets to be loaded optionally.

@liljenstolpe
Copy link

This needs to be re-based before merge. There are TTF font issues that have been fixed in upstream. The rebase causes no errors.

@muesli
Copy link
Owner

muesli commented Feb 25, 2022

This needs to be re-based before merge. There are TTF font issues that have been fixed in upstream. The rebase causes no errors.

I can rebase this in GitHub, I just need to find the time to properly review it this weekend 😃

@muesli muesli added the enhancement New feature or request label Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants