Timer widget #67
Open
Timer widget #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support timer configuration by time.Duration formats such as 1h10m15s etc. Fixes pause and resume functionality.
norrs
commented
Feb 3, 2022
| if w.data.IsPaused() { | ||
| w.data.Clear() | ||
| } else if !w.data.HasDeadline() { | ||
| w.currIndex = (w.currIndex + 1) % len(w.times) |
Comment on lines
+179
to
+181
| pausedDuration := time.Now().Sub(w.data.pausedTime) | ||
| w.data.startTime = w.data.startTime.Add(pausedDuration) | ||
| w.data.pausedTime = time.Time{} |
| w.data.startTime = w.data.startTime.Add(pausedDuration) | ||
| w.data.pausedTime = time.Time{} | ||
| } else { | ||
| w.data.startTime = time.Now() |
Comment on lines
+118
to
+131
| if !w.data.HasDeadline() { | ||
| str = Timespan(w.times[w.currIndex]).Format(w.formats[i]) | ||
| } else { | ||
| remainingDuration := time.Until(w.data.startTime.Add(w.times[w.currIndex])) | ||
| if remainingDuration < 0 && !w.underflow { | ||
| str = Timespan(w.times[w.currIndex]).Format(w.formats[i]) | ||
| w.data.Clear() | ||
| } else if remainingDuration < 0 && w.underflow { | ||
| fontColor = w.underflowColors[i] | ||
| str = Timespan(remainingDuration * -1).Format(w.formats[i]) | ||
| } else { | ||
| str = Timespan(remainingDuration).Format(w.formats[i]) | ||
| } | ||
| } |
There was a problem hiding this comment.
Should probably be a method(s) .. not really happy about how this turned out. Its a bit hard to read.
ie line 123, this is basically rendering the current timer you can start. Ideally we should be telling the types what to do .. now we are kinda asking them for information on how to generate a string to display. Abit of data jealousy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is continuation of #66 with a bit of refactor to support customized layouts as done with the Time widget.
Configuration also uses the time.Duration formats to provide timer configurations. See https://pkg.go.dev/time#ParseDuration