Skip to content

fix(downloader): list supported URL schemes in DownloadFile error #9689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mudler merged 3 commits into from
May 6, 2026
Merged

fix(downloader): list supported URL schemes in DownloadFile error #9689

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a72a40
fix(downloader): list supported URL schemes when input is unrecognized
Anai-Guo May 6, 2026
11d8c00
fix(downloader): normalize uri.go to LF line endings
Anai-Guo May 6, 2026
eec9911
fix(downloader): preserve trailing newline at end of file
Anai-Guo May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/downloader/uri.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ func (uri URI) DownloadFileWithContext(ctx context.Context, filePath, sha string
}
} else if !os.IsNotExist(err) || !URI(url).LooksLikeHTTPURL() {
// Error occurred while checking file existence
return fmt.Errorf("file %s does not exist (%v) and %s does not look like an HTTP URL", filePath, err, url)
return fmt.Errorf("could not fetch %q: local file does not exist (%v) and %q is not a recognized downloadable URL (supported schemes: %s)", filePath, err, url, strings.Join([]string{HTTPPrefix, HTTPSPrefix, LocalPrefix, HuggingFacePrefix, HuggingFacePrefix1, OllamaPrefix, OCIPrefix, OCIFilePrefix, GithubURI2}, ", "))
}

xlog.Info("Downloading", "url", url)
Expand Down
Loading