fix(ci): wire AMDGPU_TARGETS through backend build workflow - #9445
Merged
Conversation
Commit 8839a71 exposed AMDGPU_TARGETS as an ARG/ENV in Dockerfile.llama-cpp so GPU targets could be overridden, but never wired the value through the CI workflow inputs. Without it, Docker receives AMDGPU_TARGETS="" which overrides the Makefile's ?= default, causing all hipblas builds to compile only for gfx906 regardless of the target list in the Makefile. Add amdgpu-targets as a workflow_call input with the same default list as the Makefile, and pass it as AMDGPU_TARGETS in the build-args of both the push and PR build steps. Assisted-by: Claude Code:claude-sonnet-4-6 Signed-off-by: Russell Sim <rsl@simopolis.xyz>
russell
force-pushed
the
fix-amdgpu-targets
branch
from
April 20, 2026 17:01
f69d020 to
399c1de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 8839a71 exposed AMDGPU_TARGETS as an ARG/ENV in Dockerfile.llama-cpp so GPU targets could be overridden, but never wired the value through the CI workflow inputs. Without it, Docker receives AMDGPU_TARGETS="" which overrides the Makefile's ?= default, causing all hipblas builds to compile only for gfx906 regardless of the target list in the Makefile.
Add amdgpu-targets as a workflow_call input with the same default list as the Makefile, and pass it as AMDGPU_TARGETS in the build-args of both the push and PR build steps.
Assisted-by: Claude Code:claude-sonnet-4-6
Signed commits