fix: propagate validation errors #7787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes mudler#7334 The Validate() function was not checking if MCP configuration (mcp.stdio and mcp.remote) contains valid JSON. This caused malformed JSON with missing commas to be silently accepted. Changes: - Add MCP configuration validation to ModelConfig.Validate() - Properly report validation errors instead of discarding them - Add test cases for valid and invalid MCP configurations The fix ensures that malformed JSON in MCP config sections will now be caught and reported during validation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: majiayu000 <1835304752@qq.com>
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mudler
changed the title
majiayu000
deleted the
fix-7334-validate-on-model-config-does--1230-1631
branch
mudler
pushed a commit
to coffeerunhobby/LocalAI
that referenced
this pull request
Jan 2, 2026
fix: validate MCP configuration in model config Fixes mudler#7334 The Validate() function was not checking if MCP configuration (mcp.stdio and mcp.remote) contains valid JSON. This caused malformed JSON with missing commas to be silently accepted. Changes: - Add MCP configuration validation to ModelConfig.Validate() - Properly report validation errors instead of discarding them - Add test cases for valid and invalid MCP configurations The fix ensures that malformed JSON in MCP config sections will now be caught and reported during validation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: majiayu000 <1835304752@qq.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #7334
Changes
Validate()function now checks if MCP configuration (mcp.stdio and mcp.remote) contains valid JSON by callingMCPConfigFromYAML(), which will catch malformed JSON with missing commas or other syntax errorsmodel_config_loader.goto properly capture and report validation errors instead of discarding themProblem
Previously, the
Validate()function was not checking MCP configuration validity. This caused malformed JSON with missing commas to be silently accepted during validation, leading to runtime errors when the configuration was actually used.Solution
The fix adds validation that unmarshals the MCP YAML/JSON configuration. If the JSON is malformed (e.g., missing commas), the unmarshaling will fail and return an error, which is now properly caught and reported to the user.
Generated with Claude Code