fix(rocm): Rename tag suffix for hipblas whisper build to match backend config #6247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hipblas images generally have the suffix `-gpu-rocm-hipblas-X`. One exception to this currently is the hipblas build of Whisper which has the suffix `gpu-hipblas-whisper. However, as `backend/index.yaml` references the image tag for Whisper using the more consistent form (i.e. `latest-gpu-rocm-hipblas-whisper`), it is not possible to add the backend as raised in mudler#6114. Therefore, rename the suffix for hipblas whisper images to use the more consistent form, aligning with other hipblas builds as well as the expected image name in `backend/index.yaml`. Signed-off-by: Kingsley Jarrett <[email protected]>
KingJ
force-pushed
the
fix-backend-build-config-for-hipblas
branch
from
975ae9b to
2e03617
Compare
mudler
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #6114.
hipblas images generally have the suffix
-gpu-rocm-hipblas-X. One exception to this currently is the hipblas build of Whisper which has the suffix `gpu-hipblas-whisper.However, as
backend/index.yamlreferences the image tag for Whisper using the more consistent form (i.e.latest-gpu-rocm-hipblas-whisper), it is not possible to add the backend as raised in #6114.Therefore, rename the suffix for hipblas whisper images to use the more consistent form, aligning with other hipblas builds as well as the expected image name in
backend/index.yaml.Notes for Reviewers
The only other inconsistent hipblas build in
.github/workflows/backend.ymlis now-gpu-hipblas-exllama2, however as that's not referenced inbackend/index.yamli've not updated it.I've also left a comment on #6114 which goes in to a bit more detail.
Signed commits