Skip to content

Conversation

@mudler
Copy link
Owner

@mudler mudler commented Jun 20, 2025

Description

This PR try to fix issues when tagging latest images that consumes too much disk space in the worker

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@netlify
Copy link

netlify bot commented Jun 20, 2025

Deploy Preview for localai ready!

Name Link
🔨 Latest commit 8090f67
🔍 Latest deploy log https://app.netlify.com/projects/localai/deploys/6855675b0df69f00088af275
😎 Deploy Preview https://deploy-preview-5695--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mudler mudler requested a review from Copilot June 20, 2025 13:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes disk usage when tagging the “latest” container images by leveraging the build-push-action’s load feature and removing redundant docker pull steps.

  • Conditionally adds load: true to build-push steps when tagging on a Git tag.
  • Removes explicit docker pull commands before re-tagging versioned images.
  • Applies the same optimization to both the main image and backend workflows.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/image_build.yml Added load flags to reduce local pulls and removed redundant pulls
.github/workflows/backend_build.yml Added load flag for backend build and removed redundant pulls
Comments suppressed due to low confidence (2)

.github/workflows/image_build.yml:331

  • Ensure that the build-push-action load: true actually loads both the localai and quay.io versioned images into the local Docker daemon before this tag step; otherwise, docker tag may fail on missing images. If not, consider re-adding a pull or splitting builds per registry.
          docker tag localai/localai:${{ steps.meta.outputs.version }} localai/localai:${{ inputs.latest-image }}

.github/workflows/backend_build.yml:244

  • Verify that the load: true option in the build step loads the backend image locally; if it doesn’t, this docker tag will fail. Otherwise, you may need to restore an explicit pull or adjust the build step.
          docker tag localai/localai-backends:${{ steps.meta.outputs.version }} localai/localai-backends:${{ inputs.latest-image }}

@mudler mudler merged commit be3ff48 into master Jun 20, 2025
28 checks passed
@mudler mudler deleted the ci/optimize branch June 20, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants