Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc): pass by modelpath #4023

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix(grpc): pass by modelpath #4023

merged 1 commit into from
Oct 31, 2024

Conversation

mudler
Copy link
Owner

@mudler mudler commented Oct 31, 2024

Instead of trying to derive it from the model file. In backends that specify HF url this results in a fragile logic.

This pull request introduces a new ModelPath field to the ModelOptions message in backend/backend.proto and updates the relevant code to utilize this new field. The changes ensure that the ModelPath is used consistently across different parts of the codebase.

Additions and Updates to Model Options:

Code Adjustments for New Field:

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Instead of trying to derive it from the model file. In backends that
specify HF url this results in a fragile logic.

Signed-off-by: Ettore Di Giacinto <[email protected]>
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for localai ready!

Name Link
🔨 Latest commit 2c1a26e
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/6723618403bca400084624c0
😎 Deploy Preview https://deploy-preview-4023--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mudler mudler merged commit 61c964d into master Oct 31, 2024
31 checks passed
@mudler mudler deleted the feat/lora branch October 31, 2024 11:12
@mudler mudler added the bug Something isn't working label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant