feat(api): add correlationID to Track Chat requests #3668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mudler
reviewed
Sep 26, 2024
siddimore
changed the title
mudler
reviewed
Sep 27, 2024
mudler
changed the title
mudler
changed the title
|
@siddimore This looks good here! I need DCO to be cleared out before merging - can you sign-off your commits with |
yup @mudler will do it today. I also have another PR in the wings for exposing tokens_per_second as a metric. Will raise it with signed off commits. |
siddimore
force-pushed
the
add_correlation_id
branch
from
3d953cf
to
65afc23
Compare
siddimore
force-pushed
the
add_correlation_id
branch
3 times, most recently
from
714b641
to
98ab46b
Compare
mudler
approved these changes
Sep 27, 2024
Signed-off-by: Siddharth More <[email protected]>
Signed-off-by: Siddharth More <[email protected]>
Signed-off-by: Siddharth More <[email protected]>
Signed-off-by: Siddharth More <[email protected]>
Co-authored-by: Ettore Di Giacinto <[email protected]> Signed-off-by: Siddharth More <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]> Signed-off-by: Siddharth More <[email protected]>
auto-merge was automatically disabled
September 28, 2024 00:54
Head branch was pushed to by a user without write access
siddimore
force-pushed
the
add_correlation_id
branch
from
98ab46b
to
5418ce6
Compare
|
@mudler had to rebase please kindly re-approve |
mudler
approved these changes
Sep 28, 2024
|
@mudler thanks, i am PST TZ watching the build lastnight until 11:30pm noticed the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does not fix but a feature to add correlationID to track chat requests
Notes for Reviewers
Signed commits