Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django upgrade to 2.2.11 ( security recommendation from github) #1133

Closed
id2359 opened this issue Dec 18, 2019 · 3 comments
Closed

Django upgrade to 2.2.11 ( security recommendation from github) #1133

id2359 opened this issue Dec 18, 2019 · 3 comments
Assignees

Comments

@id2359
Copy link
Contributor

id2359 commented Dec 18, 2019

Follow best practice as outlined in Django docs to upgrade

@id2359 id2359 changed the title Django upgrade 3.0 Django upgrade to 2.2.9 ( security recommendation from github) Feb 5, 2020
@jithendralal
Copy link
Contributor

[INFO:2020-02-10 14:27:22,330:apps.py:14:ready] running RDRFConfig.ready ...
SystemCheckError: System check identified some issues:

ERRORS:
?: (urls.E007) The custom handler404 view 'rdrf.urls.handler404' does not take the correct number of arguments (request, exception).

id2359 added a commit that referenced this issue Feb 11, 2020
@id2359 id2359 modified the milestones: CIC Release , CIC report Feb 17, 2020
@id2359 id2359 self-assigned this Feb 24, 2020
@id2359 id2359 removed their assignment Mar 10, 2020
@id2359 id2359 removed this from the CIC report milestone Apr 7, 2020
@id2359 id2359 changed the title Django upgrade to 2.2.9 ( security recommendation from github) Django upgrade to 2.2.11 ( security recommendation from github) May 1, 2020
jithendralal pushed a commit that referenced this issue May 4, 2020
TestCase class attribute 'databases' added.
jithendralal pushed a commit that referenced this issue May 5, 2020
Bumped up sqlalchemy-utils==0.33.1 to 0.34.0
@jithendralal
Copy link
Contributor

jithendralal commented May 5, 2020

2ba6729 - 404 handler modified to match the new django version
build on Travis failed:
AssertionError: Database queries to 'clinical' are not allowed in this test. Add 'clinical' to rdrf.testing.unit.tests.ClinicalDataTestCase.databases to ensure proper test isolation and silence this failure.

d3d49ef - class attribute 'databases' added to tests
build on Travis failed:
SAWarning: The GenericFunction 'array_agg' is already registered and is going to be overriden.

7f2c650 - version bumped up sqlalchemy-utils==0.34.0
build on Travis failed:
There is 1 other session using the database. (session not closed when using a new export zip)

Similar issue: https://github.com/muccg/mtm/issues/316

Tried downgrading SQLAlchemy==1.2.5 and SQLAlchemy-Utils==0.33.1
as suggested in this issue:
fastmonkeys/stellar#77
but
docker exec -it rdrf_runservertest_1 /app/docker-entrypoint.sh bash
pip freeze
shows
SQLAlchemy==1.3.12
SQLAlchemy-Utils==0.34.0

cleaned everything and built again
SQLAlchemy==1.2.5
SQLAlchemy-Utils==0.33.1

74c55e3 - Added logging to terrain and utils and pushed the changes to see the sequence of processes, during the build on travis.

@jithendralal
Copy link
Contributor

jithendralal commented May 7, 2020

50126ab - url in stellar.yaml config files modified (template1 was removed from url) to test the effect

local build failed:
rdrf.services.io.content.export_import.exceptions.ImportError: Schema difference detected between your registry and the export file. App(s) with different schema: auth

travis build failed:
database "webapp" does not exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants