Feature/query log control #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikiDi
reviewed
Oct 4, 2024
| LOG_SPARQL_QUERIES = os.environ.get( | ||
| 'LOG_SPARQL_QUERIES', | ||
| default=LOG_SPARQL_ALL_VAR | ||
| ).lower() == 'true' |
There was a problem hiding this comment.
Since the Python boolean syntax is True (capitalized) I suggest adding that one too.
There was a problem hiding this comment.
nvm. I didn't notice the lowercasing method.
MikiDi
approved these changes
Oct 4, 2024
|
@MikiDi Does this need more review or can we merge this? :) |
|
I indicated my approval for merging this PR as-is by submitting an approval review. I don't have the rights to merge myself however. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overrides #17
Allow configuration of read and update queries separately