include all files in build #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling copy over the non compilable files. typically these are supporting files like json files, hbs, templates, ... that are expected by the app.
The previous solution copied everything through node babel but the documentation of that is a bit limited. Adding an explicit copy using rsync. co-author: @erikap
|
Merged updated master into this branch and updated implementation to explicitly copy files. Does this solution look good to you or is there a better approach? The last commit changes the implementation to explicitly copy files and could be reverted if need be. |
|
@madnificent just a short update: yes I believe this should work just as well, but haven't gotten around to testing it yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling copy over the non compilable files. typically these are supporting files like json files, hbs, templates, ... that are expected by the app.
Fixes #60