Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/coalesce handler #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ajuvercr
Copy link

@ajuvercr ajuvercr commented Aug 4, 2021

When a requests hits the cache, the cache might have an instant cached response.
When the cache gets 2 requests simultaneously with the same key, so the second should get a cached request, yet it doesn't because the cache is only updated after the request is finished.

What happens:

          cache
req1   \   |
         \ |
req2   \   |
         \ |
         / |
req1   /   |
         / |
req2   /   |

Expected:

What happens:

          cache
req1   \   |
         \ |
req2   \   |
         \ |
         / |
req1,2 /   |

This pull request alleviates this by creating a Coalescer during the request on which incoming requests can attach and get the same response as the starting request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant