-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements for ember 4 #31
base: master
Are you sure you want to change the base?
Commits on Jan 22, 2022
-
Conversion of data-table component
This conversion cannot be checked in its functionality, as we must convert the underlying components too in order to check the current setup.
Configuration menu - View commit details
-
Copy full SHA for a8ea4ae - Browse repository at this point
Copy the full SHA a8ea4aeView commit details -
Working version of pagination component
The NumberPagination component now also consumes content and sends updates.
Configuration menu - View commit details
-
Copy full SHA for e42c8d1 - Browse repository at this point
Copy the full SHA e42c8d1View commit details -
Implementation of DataTableContent up to ThSortable
This is the path that allows us to render a sortable header. Yet nothing else is currently being rendered.
Configuration menu - View commit details
-
Copy full SHA for 891d580 - Browse repository at this point
Copy the full SHA 891d580View commit details -
Upgrades rendering of data table content
The content can now be rendered in an Ember 4.x application.
Configuration menu - View commit details
-
Copy full SHA for 15208f5 - Browse repository at this point
Copy the full SHA 15208f5View commit details -
The base building blocks the search used are quite neat. We've continued to use those and were able to simplify a tiny bit due to new abstractions. This component can likely benefit from some shuffling of the code but that would require a second reading.
Configuration menu - View commit details
-
Copy full SHA for 42fff8a - Browse repository at this point
Copy the full SHA 42fff8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 852536d - Browse repository at this point
Copy the full SHA 852536dView commit details -
Remove unused functions in data-table
These had some leftover todos attached to them. Not needed.
Configuration menu - View commit details
-
Copy full SHA for bd5ccf4 - Browse repository at this point
Copy the full SHA bd5ccf4View commit details -
Blind upgrading of data-table-menu
The test cases may help us find a way out of this, but this feels like it's a sensible step to at least get the branch into a possibly sensible state.
Configuration menu - View commit details
-
Copy full SHA for e0501d9 - Browse repository at this point
Copy the full SHA e0501d9View commit details
Commits on Jan 23, 2022
-
Upgrade serializer to new construct
This provides with a few options, as summarized in the docstrings.
Configuration menu - View commit details
-
Copy full SHA for 90b2652 - Browse repository at this point
Copy the full SHA 90b2652View commit details -
Named blocks for DataTable component
This component is the first to receive support for named blocks. This allows a user to override only part of the component. The pattern that arrizes in the component is feasible to stare through and so we hope this may be a construction that we could iterate on for the other components too.
Configuration menu - View commit details
-
Copy full SHA for c798859 - Browse repository at this point
Copy the full SHA c798859View commit details -
This should allow users to use the menu once again. You don't need to extend the full component for using this anymore :)
Configuration menu - View commit details
-
Copy full SHA for 75cb4c9 - Browse repository at this point
Copy the full SHA 75cb4c9View commit details
Commits on Jan 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0e36bc8 - Browse repository at this point
Copy the full SHA 0e36bc8View commit details -
Blindly allowing various components to be configured with overrides
The idea is that we allow various slots to be used to override parts of the data table, allowing other parts to stay put. This structured could possibly be used as a guideline to styled versions of the ember-data-table.
Configuration menu - View commit details
-
Copy full SHA for 96658e7 - Browse repository at this point
Copy the full SHA 96658e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 317ed23 - Browse repository at this point
Copy the full SHA 317ed23View commit details -
Extracting all state from the current templates into a big one
The big template would make replacing parts easier from a consumer's point of view. It does mean we have a single very large template with all visible options embedded in it. Question would then be if this is easier to maintain and manage than the alternative with many components.
Configuration menu - View commit details
-
Copy full SHA for 1dafa43 - Browse repository at this point
Copy the full SHA 1dafa43View commit details
Commits on Jan 25, 2022
-
Further wrapping in components
This approach should make the template a tad easier to understand as we have removed more information-passing logic into components that don't render output themselves.
Configuration menu - View commit details
-
Copy full SHA for 96c325f - Browse repository at this point
Copy the full SHA 96c325fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fb34b9 - Browse repository at this point
Copy the full SHA 4fb34b9View commit details -
Basic controller, route and serializer
These basics should help people get started with the components. The route and controller could receive more love to allow better combination with other libraries. Not sure how much that happens at this point in time.
Configuration menu - View commit details
-
Copy full SHA for 593c0a6 - Browse repository at this point
Copy the full SHA 593c0a6View commit details -
Whilst implementing an alternative view, some thing options turned out to be missing. Adding those in.
Configuration menu - View commit details
-
Copy full SHA for 8fd7ce2 - Browse repository at this point
Copy the full SHA 8fd7ce2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bd071f - Browse repository at this point
Copy the full SHA 0bd071fView commit details
Commits on Jan 30, 2022
-
Add @customFields and @customHeaders
These are space-separated lists you may supply to indicate for which columns the :data-header and :data-cell should be rendered. When specified it will only be rendered for those cells.
Configuration menu - View commit details
-
Copy full SHA for aa48cae - Browse repository at this point
Copy the full SHA aa48caeView commit details
Commits on Feb 12, 2022
-
Introduce DSL for supplying links attached to each item at the end
This DSL should make it obvious how to add common views to be linked at the end of the view. It is possible to override the statement by using an actions block.
Configuration menu - View commit details
-
Copy full SHA for d7db4d4 - Browse repository at this point
Copy the full SHA d7db4d4View commit details -
Renaming the files ensures they don't currently run. We may want to alter these tests so they're picked up again later.
Configuration menu - View commit details
-
Copy full SHA for d8fcf6a - Browse repository at this point
Copy the full SHA d8fcf6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b8bc9e - Browse repository at this point
Copy the full SHA 5b8bc9eView commit details -
Reworking number-pagination with @erikap
The number pagination has a concept of the server pagination on the outside and human pagination on the inside. Some features could be added, but this is an easier to understand workflow for the features that exist now.
Configuration menu - View commit details
-
Copy full SHA for 95f8e39 - Browse repository at this point
Copy the full SHA 95f8e39View commit details
Commits on Jun 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 67a8893 - Browse repository at this point
Copy the full SHA 67a8893View commit details
Commits on Jun 26, 2024
-
Add documentation backlinks in components
The components hbs files mostly follow a logical name but it can still be a bit confusing. We're adding the breadcrumbs now so we can find our way back more easily.
Configuration menu - View commit details
-
Copy full SHA for 3a77e01 - Browse repository at this point
Copy the full SHA 3a77e01View commit details -
These field objects contain information fetched from various configuration parameters and will make it easier to provide certain overrides by providing known information through a single interface. Co-author: @erikap
Configuration menu - View commit details
-
Copy full SHA for 5daded0 - Browse repository at this point
Copy the full SHA 5daded0View commit details -
Rename data-table to dataTable in arguments
Cleaner wording, replaced semi-automatically. Co-author: @erikap
Configuration menu - View commit details
-
Copy full SHA for 49544a2 - Browse repository at this point
Copy the full SHA 49544a2View commit details -
Rename lineNumbers to enableLineNumbers
More obvious naming. Co-author: @erikap
Configuration menu - View commit details
-
Copy full SHA for 7c5baef - Browse repository at this point
Copy the full SHA 7c5baefView commit details -
Provide warnings when update functions are not supplied
A warning is shown on missing update functions. This will not error before they're used but it's a bit more helpful. Co-author: @erikap
Configuration menu - View commit details
-
Copy full SHA for a810f03 - Browse repository at this point
Copy the full SHA a810f03View commit details -
This only appears in the RawDataTable component at this point. Best to update it as it will likely become the preferred starting point.
Configuration menu - View commit details
-
Copy full SHA for 1c15793 - Browse repository at this point
Copy the full SHA 1c15793View commit details
Commits on Jul 18, 2024
-
Remove usage of customFields and parsedFields
These properties have been replaced with the fields object. Co-author: @erikap
Configuration menu - View commit details
-
Copy full SHA for 4ef37ed - Browse repository at this point
Copy the full SHA 4ef37edView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa5dc83 - Browse repository at this point
Copy the full SHA fa5dc83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f553d7 - Browse repository at this point
Copy the full SHA 9f553d7View commit details
Commits on Jul 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0911213 - Browse repository at this point
Copy the full SHA 0911213View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6eeb8c - Browse repository at this point
Copy the full SHA d6eeb8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fdb74c0 - Browse repository at this point
Copy the full SHA fdb74c0View commit details -
Uses the human element towards the implementor which hopefully makes things a bit easier to implement. Co-author: @erikap
Configuration menu - View commit details
-
Copy full SHA for 5b805c1 - Browse repository at this point
Copy the full SHA 5b805c1View commit details -
Add summarized page options to pagination component
Co-author: @madnificent From @rollvolet <3
Configuration menu - View commit details
-
Copy full SHA for 2fae217 - Browse repository at this point
Copy the full SHA 2fae217View commit details -
Configuration menu - View commit details
-
Copy full SHA for 675130f - Browse repository at this point
Copy the full SHA 675130fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c1dac2f - Browse repository at this point
Copy the full SHA c1dac2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 91d3cec - Browse repository at this point
Copy the full SHA 91d3cecView commit details
Commits on Jul 23, 2024
-
Work towards new readme for ember-data-table
The readme would need to be completely revamped for the new data table. This should go a long way towards that.
Configuration menu - View commit details
-
Copy full SHA for a46b511 - Browse repository at this point
Copy the full SHA a46b511View commit details -
More work towards README of new Ember Data Table
This documents the various parts which can be overridden. It's probably the easiest to check the specific design implementation but this might help determine the intent.
Configuration menu - View commit details
-
Copy full SHA for 35b89ec - Browse repository at this point
Copy the full SHA 35b89ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for f789812 - Browse repository at this point
Copy the full SHA f789812View commit details -
Fix location of some handlebars TODO comments
These were within a component and they're not allowed there.
Configuration menu - View commit details
-
Copy full SHA for b4c46c4 - Browse repository at this point
Copy the full SHA b4c46c4View commit details -
Add support for view argument to limit arguments to pass
This is a wrapper object containing: - size - page - filter - sort - isLoading - updatePage - updatePageSize - updateFilter - updateSort It is an opaque object from the user's point of view. All current arguments take precedence making it easy to override. The default case becomes shorter which is great to show what's special about the specific Data Table at hand and thus lowers mental overhead for the default case.
Configuration menu - View commit details
-
Copy full SHA for 623311b - Browse repository at this point
Copy the full SHA 623311bView commit details
Commits on Jul 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 505ed2c - Browse repository at this point
Copy the full SHA 505ed2cView commit details
Commits on Jul 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 527556e - Browse repository at this point
Copy the full SHA 527556eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 979a6b4 - Browse repository at this point
Copy the full SHA 979a6b4View commit details -
Export attribute-to-sort-params as util function
Makes it easier for users to fallback to the default behaviour when implementing custom sort parameters for an attribute.
Configuration menu - View commit details
-
Copy full SHA for 547fbdf - Browse repository at this point
Copy the full SHA 547fbdfView commit details
Commits on Oct 16, 2024
-
Add peer dependency on ember-data
The addon imports the JSONAPI serializer from ember-data
Configuration menu - View commit details
-
Copy full SHA for d2b0bd5 - Browse repository at this point
Copy the full SHA d2b0bd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c56e562 - Browse repository at this point
Copy the full SHA c56e562View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f18789 - Browse repository at this point
Copy the full SHA 1f18789View commit details -
Configuration menu - View commit details
-
Copy full SHA for 703d827 - Browse repository at this point
Copy the full SHA 703d827View commit details