Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements for ember 4 #31

Open
wants to merge 56 commits into
base: master
Choose a base branch
from
Open

Commits on Jan 22, 2022

  1. Conversion of data-table component

    This conversion cannot be checked in its functionality, as we must
    convert the underlying components too in order to check the current
    setup.
    madnificent committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    a8ea4ae View commit details
    Browse the repository at this point in the history
  2. Working version of pagination component

    The NumberPagination component now also consumes content and sends
    updates.
    madnificent committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    e42c8d1 View commit details
    Browse the repository at this point in the history
  3. Implementation of DataTableContent up to ThSortable

    This is the path that allows us to render a sortable header.  Yet
    nothing else is currently being rendered.
    madnificent committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    891d580 View commit details
    Browse the repository at this point in the history
  4. Upgrades rendering of data table content

    The content can now be rendered in an Ember 4.x application.
    madnificent committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    15208f5 View commit details
    Browse the repository at this point in the history
  5. Upgrade search to Ember 4

    The base building blocks the search used are quite neat.  We've
    continued to use those and were able to simplify a tiny bit due to new
    abstractions.  This component can likely benefit from some shuffling of
    the code but that would require a second reading.
    madnificent committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    42fff8a View commit details
    Browse the repository at this point in the history
  6. Get filter from route

    Filter was not passed correctly.
    madnificent committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    852536d View commit details
    Browse the repository at this point in the history
  7. Remove unused functions in data-table

    These had some leftover todos attached to them.  Not needed.
    madnificent committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    bd5ccf4 View commit details
    Browse the repository at this point in the history
  8. Blind upgrading of data-table-menu

    The test cases may help us find a way out of this, but this feels like
    it's a sensible step to at least get the branch into a possibly sensible
    state.
    madnificent committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    e0501d9 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2022

  1. Upgrade serializer to new construct

    This provides with a few options, as summarized in the docstrings.
    madnificent committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    90b2652 View commit details
    Browse the repository at this point in the history
  2. Named blocks for DataTable component

    This component is the first to receive support for named blocks.  This
    allows a user to override only part of the component.
    
    The pattern that arrizes in the component is feasible to stare through
    and so we hope this may be a construction that we could iterate on for
    the other components too.
    madnificent committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    c798859 View commit details
    Browse the repository at this point in the history
  3. re-introduce menu

    This should allow users to use the menu once again.  You don't need to
    extend the full component for using this anymore :)
    madnificent committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    75cb4c9 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Configuration menu
    Copy the full SHA
    0e36bc8 View commit details
    Browse the repository at this point in the history
  2. Blindly allowing various components to be configured with overrides

    The idea is that we allow various slots to be used to override parts of
    the data table, allowing other parts to stay put.  This structured could
    possibly be used as a guideline to styled versions of the
    ember-data-table.
    madnificent committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    96658e7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    317ed23 View commit details
    Browse the repository at this point in the history
  4. Extracting all state from the current templates into a big one

    The big template would make replacing parts easier from a consumer's
    point of view.  It does mean we have a single very large template with
    all visible options embedded in it.  Question would then be if this is
    easier to maintain and manage than the alternative with many components.
    madnificent committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    1dafa43 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2022

  1. Further wrapping in components

    This approach should make the template a tad easier to understand as we
    have removed more information-passing logic into components that don't
    render output themselves.
    madnificent committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    96c325f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4fb34b9 View commit details
    Browse the repository at this point in the history
  3. Basic controller, route and serializer

    These basics should help people get started with the components.  The
    route and controller could receive more love to allow better combination
    with other libraries.  Not sure how much that happens at this point in
    time.
    madnificent committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    593c0a6 View commit details
    Browse the repository at this point in the history
  4. Minor updates to the API

    Whilst implementing an alternative view, some thing options turned out
    to be missing.  Adding those in.
    madnificent committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    8fd7ce2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0bd071f View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2022

  1. Add @customFields and @customHeaders

    These are space-separated lists you may supply to indicate for which
    columns the :data-header and :data-cell should be rendered.  When
    specified it will only be rendered for those cells.
    madnificent committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    aa48cae View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2022

  1. Introduce DSL for supplying links attached to each item at the end

    This DSL should make it obvious how to add common views to be linked at
    the end of the view.  It is possible to override the statement by using
    an actions block.
    madnificent committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    d7db4d4 View commit details
    Browse the repository at this point in the history
  2. Disable or update old tests

    Renaming the files ensures they don't currently run.  We may want to
    alter these tests so they're picked up again later.
    madnificent committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    d8fcf6a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5b8bc9e View commit details
    Browse the repository at this point in the history
  4. Reworking number-pagination with @erikap

    The number pagination has a concept of the server pagination on the
    outside and human pagination on the inside.  Some features could be
    added, but this is an easier to understand workflow for the features
    that exist now.
    madnificent committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    95f8e39 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Improvements on naming and anchoring

    Co-author: @erikap
    madnificent committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    67a8893 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Add documentation backlinks in components

    The components hbs files mostly follow a logical name but it can still
    be a bit confusing.  We're adding the breadcrumbs now so we can find our
    way back more easily.
    madnificent committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    3a77e01 View commit details
    Browse the repository at this point in the history
  2. Introduce rich field objects

    These field objects contain information fetched from various
    configuration parameters and will make it easier to provide certain
    overrides by providing known information through a single interface.
    
    Co-author: @erikap
    madnificent committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5daded0 View commit details
    Browse the repository at this point in the history
  3. Rename data-table to dataTable in arguments

    Cleaner wording, replaced semi-automatically.
    
    Co-author: @erikap
    madnificent committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    49544a2 View commit details
    Browse the repository at this point in the history
  4. Rename lineNumbers to enableLineNumbers

    More obvious naming.
    
    Co-author: @erikap
    madnificent committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7c5baef View commit details
    Browse the repository at this point in the history
  5. Provide warnings when update functions are not supplied

    A warning is shown on missing update functions.  This will not error
    before they're used but it's a bit more helpful.
    
    Co-author: @erikap
    madnificent committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a810f03 View commit details
    Browse the repository at this point in the history
  6. Rename isloading to isLoading

    This only appears in the RawDataTable component at this point.  Best to
    update it as it will likely become the preferred starting point.
    madnificent committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    1c15793 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Remove usage of customFields and parsedFields

    These properties have been replaced with the fields object.
    
    Co-author: @erikap
    madnificent committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    4ef37ed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fa5dc83 View commit details
    Browse the repository at this point in the history
  3. Cleanup search variables

    Co-author: @erikap
    madnificent committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    9f553d7 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Customizable sort parameters per field

    Co-author: @erikap
    madnificent committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    0911213 View commit details
    Browse the repository at this point in the history
  2. Disable prettier in eslint

    Co-author: @madnificent
    erikap committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    d6eeb8c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fdb74c0 View commit details
    Browse the repository at this point in the history
  4. Enhance pagination

    Uses the human element towards the implementor which hopefully makes
    things a bit easier to implement.
    
    Co-author: @erikap
    madnificent committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    5b805c1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2fae217 View commit details
    Browse the repository at this point in the history
  6. Improvements to menu

    Co-author: @erikap
    madnificent committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    675130f View commit details
    Browse the repository at this point in the history
  7. Cleaner handling of pages

    Co-author: @erikap
    madnificent committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    c1dac2f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    91d3cec View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Work towards new readme for ember-data-table

    The readme would need to be completely revamped for the new data table.
    This should go a long way towards that.
    madnificent committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    a46b511 View commit details
    Browse the repository at this point in the history
  2. More work towards README of new Ember Data Table

    This documents the various parts which can be overridden.  It's probably
    the easiest to check the specific design implementation but this might
    help determine the intent.
    madnificent committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    35b89ec View commit details
    Browse the repository at this point in the history
  3. Nicer wording in README

    madnificent committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f789812 View commit details
    Browse the repository at this point in the history
  4. Fix location of some handlebars TODO comments

    These were within a component and they're not allowed there.
    madnificent committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b4c46c4 View commit details
    Browse the repository at this point in the history
  5. Add support for view argument to limit arguments to pass

    This is a wrapper object containing:
    - size
    - page
    - filter
    - sort
    - isLoading
    - updatePage
    - updatePageSize
    - updateFilter
    - updateSort
    
    It is an opaque object from the user's point of view.  All current
    arguments take precedence making it easy to override.  The default case
    becomes shorter which is great to show what's special about the specific
    Data Table at hand and thus lowers mental overhead for the default case.
    madnificent committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    623311b View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Configuration menu
    Copy the full SHA
    505ed2c View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Fix passing of sort argument

    erikap committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    527556e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    979a6b4 View commit details
    Browse the repository at this point in the history
  3. Export attribute-to-sort-params as util function

    Makes it easier for users to fallback to the default behaviour when
    implementing custom sort parameters for an attribute.
    erikap committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    547fbdf View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Add peer dependency on ember-data

    The addon imports the JSONAPI serializer from ember-data
    erikap committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d2b0bd5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c56e562 View commit details
    Browse the repository at this point in the history
  3. Bump ember-auto-import to v2

    erikap committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    1f18789 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    703d827 View commit details
    Browse the repository at this point in the history