-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow white space for json simple xml element decorator #12
base: master
Are you sure you want to change the base?
Conversation
…l-element-decorator allow whitespace for json simple xml element decorator
…l-element-decorator Reformat
…l-element-decorator Helper allow white space
…l-element-decorator Helper allow white space
Hi @shawkiIIalasy, Thanks for the contribution. It would be nice of you to add a detailed description of what this pull request solves or improves Code snippet comparisons of the current package behavior vs your desired behavior would make a great illustration. |
@shawkiIIalasy I've added a commit to test allowing significant white space in indented xml |
Description Added, Please check |
@mtvbrianking please check |
@mtvbrianking Can you check? |
Hi @shawkiAlasy The unit tests are still failing |
@mtvbrianking Tests: passed |
Add flexibility for allowing white spaces when elements have white space
Current behaviour:
Desired behaviour
Case
We compare an encrypted XML request from third parties with our request but because the encrypted request was encrypted with whitespace will not match our request, generally, we don't want to edit any value of the XML request