Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Notice: Class Bmatovu\LaravelXml\Support\XMLElement #3

Open
trollfalgar opened this issue Aug 29, 2020 · 10 comments
Open
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@trollfalgar
Copy link
Contributor

Can you check this:

Deprecation Notice: Class Bmatovu\LaravelXml\Support\XMLElement located in C:/laragon/www/project/vendor/bmatovu/laravel-xml/src\Support\XmlElement.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar://C:/ProgramData/ComposerSetup/bin/composer.phar/s rc/Composer/Autoload/ClassMapGenerator.php:201

Something in XmlElement.php does not comply with psr-4.

Thanks.

@mtvbrianking
Copy link
Owner

Let me review this.

Thanks

@trollfalgar
Copy link
Contributor Author

@mtvbrianking thanks.

@mtvbrianking
Copy link
Owner

@trollfalgar what are the steps to reproduce this issue?

And which versions of the package, and version of composer are you using?

@trollfalgar
Copy link
Contributor Author

trollfalgar commented Aug 29, 2020

Everytime I run the command: composer update or composer dump-autoload .
Just run one of this commands and you'll see it.

I'm using version 2.0.0 of the package.
Composer 1.10.8 and 1.10.10

@trollfalgar
Copy link
Contributor Author

@mtvbrianking with version 1.8.6 of composer, this warning is not appearing.

@mtvbrianking
Copy link
Owner

@trollfalgar I think, I found the issue...

class XMLElement extends \SimpleXMLElement {
   // ...
}

SimpleXMLElement is not auto-loaded using PSR-4.

Fixing this will require a major release for backward compatibility.

@mtvbrianking mtvbrianking added enhancement New feature or request help wanted Extra attention is needed labels Aug 29, 2020
@trollfalgar
Copy link
Contributor Author

trollfalgar commented Aug 29, 2020

@trollfalgar I think, I found the issue...

class XMLElement extends \SimpleXMLElement {
   // ...
}

SimpleXMLElement is not auto-loaded using PSR-4.

Fixing this will require a major release for backward compatibility.

I thought that could be it.
I'll be doing some research, if I found some solution before you, I'll make a PR.

Maybe using DOMDocument class???

@mtvbrianking
Copy link
Owner

Great, I could use some help on this 🤝

mtvbrianking added a commit that referenced this issue Feb 20, 2022
@njugunanduati
Copy link

any answer on this issue @mtvbrianking ?

@mtvbrianking
Copy link
Owner

None. Issue is still open to PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants