Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace imp.load_source() #204

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Replace imp.load_source() #204

merged 1 commit into from
Aug 13, 2023

Conversation

musicinmybrain
Copy link
Contributor

Fix #203.

This is straight out of https://docs.python.org/3.12/whatsnew/3.12.html, as suggested in #203 (comment), with the choice to cache in sys.modules so re-imported modules are not multiply-executed.

Nothing explodes when I run the tests, but I haven’t attempted to set up a test cluster, so a lot of tests are skipped.

@musicinmybrain
Copy link
Contributor Author

The CI tests passed, so I think this works!

@mtth mtth merged commit a786112 into mtth:master Aug 13, 2023
5 checks passed
@mtth
Copy link
Owner

mtth commented Aug 13, 2023

Thanks @musicinmybrain!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python 3.12
2 participants