Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass actual annotation to an AttributeStrategy to allow customization #237

Closed
NBau opened this issue Feb 6, 2017 · 5 comments
Closed

pass actual annotation to an AttributeStrategy to allow customization #237

NBau opened this issue Feb 6, 2017 · 5 comments

Comments

@NBau
Copy link

NBau commented Feb 6, 2017

Since the generic case for supporting @pattern as described in #218 will probably not be available very soon, a temporary enhancement could be to support providing custom manufacturers for specific patterns.
Right now, I cannot see an easy way to provide such a manufacturer since, e.g. the AttributeStrategy does not get passed the instance of the annotation in the getValue method.

@daivanov
Copy link
Collaborator

daivanov commented Feb 6, 2017

And why do we have two issues for the same problem? Please, use issue #218, which is already open.

@daivanov daivanov closed this as completed Feb 6, 2017
@NBau
Copy link
Author

NBau commented Feb 6, 2017 via email

@daivanov daivanov changed the title add support for custom @Pattern in BeanValidation strategy pass actual annotation to an AttributeStrategy to allow customization Feb 6, 2017
@daivanov daivanov reopened this Feb 6, 2017
daivanov added a commit to daivanov/joinmo that referenced this issue Feb 6, 2017
@daivanov
Copy link
Collaborator

daivanov commented Feb 8, 2017

Some improvements to the issue was released in Podam 7.0.5.

@dedece35
Copy link
Contributor

dedece35 commented Nov 7, 2017

As @daivanov said and with last release of Podam (7.1.0.RELEASE), I tested and succedded to customize my Tests using POJOs containing @pattern annotation.
I did this with a Strategy like in Tests written by @daivanov in commit daivanov@79be6f8
I think @daivanov you can close this issue.

@daivanov
Copy link
Collaborator

daivanov commented Nov 8, 2017

Yes, I assume this was about custom annotation handlers. But for generic pattern support with some library we have Issue #218.

@daivanov daivanov closed this as completed Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants