-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass actual annotation to an AttributeStrategy to allow customization #237
Comments
And why do we have two issues for the same problem? Please, use issue #218, which is already open. |
Sorry, I was not sure how to do it differently. My idea was, instead of trying to solve the issue in #218 (I.e. Have a general way of supporting all patterns), just provide a way to register individual manufacturers for different patterns. This way, someone who wants to use the library but has some particular pattern annotation can hand-craft a specific manufacturer just for this case. Just like a custom type manufacturer. Unfortunately, this is not possible right now, since the AttributeStrategy does not have access to the annotation instance. Additionally, this would allow to support other custom Annotations as well.
… On 6 Feb 2017, at 18:43, Daniil Ivanov ***@***.***> wrote:
And why do we have two issues for the same problem?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
…stomization for Issue mtedone#237
Some improvements to the issue was released in Podam 7.0.5. |
As @daivanov said and with last release of Podam (7.1.0.RELEASE), I tested and succedded to customize my Tests using POJOs containing @pattern annotation. |
Yes, I assume this was about custom annotation handlers. But for generic pattern support with some library we have Issue #218. |
Since the generic case for supporting @pattern as described in #218 will probably not be available very soon, a temporary enhancement could be to support providing custom manufacturers for specific patterns.
Right now, I cannot see an easy way to provide such a manufacturer since, e.g. the AttributeStrategy does not get passed the instance of the annotation in the getValue method.
The text was updated successfully, but these errors were encountered: