Skip to content

update for bot advice #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RAY-316 merged 3 commits into from
Dec 2, 2021
Merged

update for bot advice #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6053c72
update bot advice
RAY-316 Dec 2, 2021
672f312
Merge branch 'helper-update-2' of https://github.com/msyyc/azure-sdk-…
RAY-316 Dec 2, 2021
be9e9bc
update
RAY-316 Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions scripts/release_helper/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class IssueProcess:
# will be changed by order
issue = None # issue that needs to handle
assignee = ''
bot = [] # bot advice to help SDK owner
bot = '' # bot advice to help SDK owner
target_readme_tag = '' # swagger content that customers want
readme_link = '' # https link which swagger definition is in
default_readme_tag = '' # configured in `README.md`
Expand Down Expand Up @@ -199,10 +199,23 @@ def auto_assign(self) -> None:
self.update_issue_instance()
self.add_label(AUTO_ASSIGN_LABEL)

def bot_advice(self):
latest_comments = ''
comments = [(comment.updated_at.timestamp(), comment.user.login) for comment in
self.issue_package.issue.get_comments()]
comments.sort()
if comments:
latest_comments = comments[-1][1]
if self.issue_package.issue.comments == 0:
self.bot = 'new issue ! <br>'
elif latest_comments not in self.language_owner:
self.bot = 'new comment. <br>'

def run(self) -> None:
# common part(don't change the order)
self.auto_assign() # necessary flow
self.auto_parse() # necessary flow
self.bot_advice()


class Common:
Expand Down Expand Up @@ -264,7 +277,6 @@ def run(self):
self.output_md(items)



def common_process(issues: List[IssuePackage]):
instance = Common(issues, _ASSIGNEE_TOKEN, _LANGUAGE_OWNER)
instance.run()
1 change: 1 addition & 0 deletions scripts/release_helper/java.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ def __init__(self, issues, assignee_token, language_owner):
self.file_out_name = 'release_java_status.md'



def java_process(issues: List[Any]):
instance = Java(issues, _ASSIGNEE_TOKEN_JAVA, _JAVA_OWNER)
instance.run()
1 change: 0 additions & 1 deletion scripts/release_helper/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ def main():
issues = collect_open_issues()
language = os.getenv('LANGUAGE')
languages = {_CONVERT[language]: _LANGUAGES[_CONVERT[language]]} if language in _CONVERT else _LANGUAGES
print(languages,'++++++++++')
for language in languages:
language_issues = select_language_issues(issues, language)
languages[language](language_issues)
Expand Down