Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ncurses] Nano editor sets wrong fg/bg colors #4945

Closed
1 task done
ivrntsv opened this issue Oct 3, 2024 · 3 comments · Fixed by #4946
Closed
1 task done

[ncurses] Nano editor sets wrong fg/bg colors #4945

ivrntsv opened this issue Oct 3, 2024 · 3 comments · Fixed by #4946
Labels

Comments

@ivrntsv
Copy link

ivrntsv commented Oct 3, 2024

Description / Steps to reproduce the issue

  1. Set mintty theme to kohlrausch. This way it's more evident as kohlrausch is black on white theme. Though, with other themes (but not all) it's the same.
  2. Run nano.

For the full story please read the thread following the links: start, continuation.

What helped is downgrading ncurses package from 6.5.20240831 to 6.5 version.

Expected behavior

Nano respects theme colors.

Actual behavior

Nano uses white foreground and black background colors.

Verification

Windows Version

MSYS_NT-10.0-19045

Are you willing to submit a PR?

No response

@ivrntsv ivrntsv added the bug label Oct 3, 2024
@lazka
Copy link
Member

lazka commented Oct 4, 2024

I can confirm:

  • the issue
  • downgrading ncurses solves it
  • the issue doesn't exist in cygwin which has a slightly older ncurses

@ivrntsv
Copy link
Author

ivrntsv commented Oct 4, 2024

Commit f0899bf introduced ncurses 6.5.20240831 and enabled term-driver. I disabled term-driver back. It seems to work.

@lazka
Copy link
Member

lazka commented Oct 4, 2024

confirmed, thanks

lazka added a commit to lazka/MSYS2-packages that referenced this issue Oct 4, 2024
It breaks colors with nano for some reason, see
msys2#4945

Fixes msys2#4945
@lazka lazka closed this as completed in 6e49e58 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants