Skip to content

Update libtorrent-rasterbar to v2.0.1#7372

Closed
Amphaal wants to merge 1 commit intomsys2:masterfrom
Amphaal:patch-1
Closed

Update libtorrent-rasterbar to v2.0.1#7372
Amphaal wants to merge 1 commit intomsys2:masterfrom
Amphaal:patch-1

Conversation

@Amphaal
Copy link
Copy Markdown
Contributor

@Amphaal Amphaal commented Dec 2, 2020

@Alexpux, do you think, since libtorrent v2.0 introduces API breakage (https://libtorrent.org/upgrade_to_2.0-ref.html), that we should rather make v2.0 available from another msys package, since v1.2 is still maintained ? (https://github.com/arvidn/libtorrent/releases/tag/v1.2.11)

Cheers !

@lazka
Copy link
Copy Markdown
Member

lazka commented Dec 2, 2020

We only have qbittorrent depending on it. Does qbittorrent support 2.x?

@Amphaal
Copy link
Copy Markdown
Contributor Author

Amphaal commented Dec 2, 2020

qbittorrent/qBittorrent#13783, Looks like it is planned at some point.

@lazka
Copy link
Copy Markdown
Member

lazka commented Dec 2, 2020

I dont see any mention of 2.x there

@Amphaal
Copy link
Copy Markdown
Contributor Author

Amphaal commented Dec 2, 2020

Mb, @FranciscoPombal was considering a v2.x port of libtorrent for vcpkg, not for qBittorrent per se. microsoft/vcpkg#14293, @glassez also talked there about creating a distinct package for v2.x.

@lazka
Copy link
Copy Markdown
Member

lazka commented Dec 2, 2020

You can bump pkgrel of qbittorrent in this PR to see if it builds. As for the other things you mentioned, I don't understand why that's relevant here.

@FranciscoPombal
Copy link
Copy Markdown

Thanks for bringing me in the loop.

qBittorrent is still not ready for v2. A few commits enabling support for v2 have been recently merged, but we're not there yet.

I must say I don't think it's fair for qBittorrent to hold an entire ecosystem back, but, on the other hand, I doubt we're the only project still making active use of 1.2.x, and 1.2.x is still maintained upstream.

This is why I proposed the compromise solution of making v2 available as a separate package for now, in vcpkg (there is somewhat of a precedent in other packages). Is that feasible for msys2 as well?

As far as vcpkg is concerned, it's actually not the end of the world for qBittorrent if the libtorrent package were bumped to 2.0. We can quite easily work around that with a simple "overlay port" (https://github.com/microsoft/vcpkg/blob/master/docs/specifications/ports-overlay.md). If msys2 were to move forward with a single v2 package in the short term, is there a similar escape hatch available?

@lazka
Copy link
Copy Markdown
Member

lazka commented Dec 3, 2020

@Amphaal ah, you mentioned the right people. sorry I didn't get that.

The rules for packaging multiple version in MSYS2 are similar to Linux distros, it's possible by creating a new package (with a new name) and adding a conflict to the old one, but ideally we would just wait a bit.

If you have a need for the new version then go ahead and create a "mingw-w64-libtorrent-rasterbar2" package that conflicts with "mingw-w64-libtorrent-rasterbar"

@Amphaal
Copy link
Copy Markdown
Contributor Author

Amphaal commented Dec 3, 2020

I'll then close this draft and follow @lazka instructions ! Thank you guys for your insights.

@Amphaal Amphaal closed this Dec 3, 2020
@Amphaal Amphaal deleted the patch-1 branch December 3, 2020 15:16
@Biswa96
Copy link
Copy Markdown
Member

Biswa96 commented Dec 3, 2020

If you have a need for the new version then go ahead and create a "mingw-w64-libtorrent-rasterbar2"

I also requested this type of thing for imagemagick version 6 required for inkscape. But Alexpux denied.

@lazka
Copy link
Copy Markdown
Member

lazka commented Dec 3, 2020

I also requested this type of thing for imagemagick version 6 required for inkscape. But Alexpux denied.

arch seems to have a trimmed down version with just the lib: https://www.archlinux.org/packages/extra/x86_64/libmagick6/

if that helps inkscape and doesn't conflict with 7, go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants