nix: init at 2.33.0

[puffnfresh]

I haven't done a build in a chroot so hopefully I got all the dependencies.

The output executable is not useful at the moment. If you try to run this package, it will crash, because the Nix codebase currently has lots of problems with handling Windows paths. Even after the big task of fixing paths, we'll have to handle process management, making a useful Windows standard environment, adding tests, and lots of other things.

I think it makes sense to not merge this package, until Nix has a minimal working Windows release. What do you think @Ericson2314?

Fixes #22459.

[Ericson2314]

Yeah fine with me just keeping this draft for now.

[ognevny]

CLANG64 fails with:

Details

FAILED: src/libutil/libnixutil.dll.p/windows_environment-variables.cc.obj 
  "clang++" "-Isrc/libutil/libnixutil.dll.p" "-Isrc/libutil" "-I../nix-2.25.0/src/libutil" "-Isrc/libutil/windows" "-I../nix-2.25.0/src/libutil/windows" "-fdiagnostics-color=always" "-D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_FAST" "-D_FILE_OFFSET_BITS=64" "-Wall" "-Winvalid-pch" "-std=c++2a" "-include" "config-util.hh" "-Wdeprecated-copy" "-Werror=suggest-override" "-Werror=switch" "-Werror=switch-enum" "-Werror=unused-result" "-Wignored-qualifiers" "-Wimplicit-fallthrough" "-Wno-deprecated-declarations" "-D_WIN32_WINNT=0x0602" "-march=nocona" "-msahf" "-mtune=generic" "-O2" "-pipe" "-Wp,-D_FORTIFY_SOURCE=2" "-fstack-protector-strong" "-Wp,-D__USE_MINGW_ANSI_STDIO=1" "-DBOOST_CONTEXT_DYN_LINK=1" "-DBOOST_COROUTINES_DYN_LINK=1" "-DBOOST_ALL_NO_LIB" "-pthread" -MD -MQ src/libutil/libnixutil.dll.p/windows_environment-variables.cc.obj -MF "src/libutil/libnixutil.dll.p/windows_environment-variables.cc.obj.d" -o src/libutil/libnixutil.dll.p/windows_environment-variables.cc.obj "-c" ../nix-2.25.0/src/libutil/windows/environment-variables.cc
  ../nix-2.25.0/src/libutil/windows/environment-variables.cc:16:31: error: non-constant-expression cannot be narrowed from type 'DWORD' (aka 'unsigned long') to 'wchar_t' in initializer list [-Wc++11-narrowing]
     16 |     std::wstring value{L'\0', bufferSize};
        |                               ^~~~~~~~~~
  ../nix-2.25.0/src/libutil/windows/environment-variables.cc:16:31: note: insert an explicit cast to silence this issue
  
     16 |     std::wstring value{L'\0', bufferSize};
  
        |                               ^~~~~~~~~~
  
        |                               static_cast<wchar_t>( )
  
  1 error generated.

[Ericson2314]

NixOS/nix#11856 OK this would fix the one build failure.

[Freed-Wu]

Related:

• https://discourse.nixos.org/t/nix-on-windows/1113/118
• https://discourse.nixos.org/t/dropping-cygwin-support/3425/17
• https://github.com/nix-windows/nix

[Ericson2314]

We should be able to bump this to the latest release and then it will pass for all platforms.

[ognevny]

We should be able to bump this to the latest release and then it will pass for all platforms.

you may create a branch in your fork if needed

[Ericson2314]

I have access to the org repo this is coming from, so I will just try to rebase it.

[Ericson2314]

I need to get my VM working, so this is an untested push, but CI will let me know.

[Ericson2314]

Hmm, looks like boost regex isn't yet part of the boost package?

   Run-time dependency Boost (found: container | missing: regex) found: NO (tried system)
  
  nix-2.30.2/src/libstore/meson.build:97:8: ERROR: Dependency "boost" not found, tried system

[Eveeifyeve]

I know the issue, libboost needs to be pkg-config based and we could look into shipping pkg-config-lite to windows.

[Ericson2314]

@Eveeifyeve please add the CFLAG -Wno-error=sign-compare when the compiler is clang. That will fix the build failure. There are hopefully some other examples of this in this repo you can use to figure out how to do that.

[Ericson2314]

https://github.com/mingw-w64/mingw-w64/blob/c4ae0f47b9adf0b6b91dcc906f5b1fbfe342bb42/mingw-w64-headers/include/psdk_inc/_fd_types.h#L21

Hmm maybe it really is this, contra the standard, and we should patch nix.

[Ericson2314]

NixOS/nix#14817 this will fix the build, once it is backported to 2.33.

[Eveeifyeve]

@ognevny Could you please rerun the CLANGARM64 github action? There seems to be some werid edgecase.

[ognevny]

sometimes we have such network issues

[Eveeifyeve]

It builds, but doesn't function.

[ognevny]

It builds, but doesn't function.

and it wasn't tested before..?

[Eveeifyeve]

It builds, but doesn't function.

and it wasn't tested before..?

Yes it was working in the previous version, but something now we messed up with loading dlls.

[Ericson2314]

Overall it's really nice to see this finally all green in CI, but yes Nix is pretty busted when compiling with mingw right now in terms of actual behavior.

We are also pursuing building Nix with Cygwin and with the MSVC ABI in parallel. The Cygwin one is going to be actually usable first, and we could look at packaging that in MSYS-PACKAGES likewise, though some deps might be missing in there that makes this harder.

(Also now that we have native Cygwin builds happening, I'm hoping to follow the MSYS playbook and cross compile Cygwin->Mingw in Nixpkgs.)

[Eveeifyeve]

Overall it's really nice to see this finally all green in CI, but yes Nix is pretty busted when compiling with mingw right now in terms of actual behavior.

We are also pursuing building Nix with Cygwin and with the MSVC ABI in parallel. The Cygwin one is going to be actually usable first, and we could look at packaging that in MSYS-PACKAGES likewise, though some deps might be missing in there that makes this harder.

(Also now that we have native Cygwin builds happening, I'm hoping to follow the MSYS playbook and cross compile Cygwin->Mingw in Nixpkgs.)

The biggest problem right now is that MSYS2 doesn't even work right now due to an absolute path issue.