Skip to content

Conversation

@kou
Copy link
Contributor

@kou kou commented Oct 19, 2022

Because this depends on aws-c-common.

Because this depends on aws-c-common.
@MehdiChinoune
Copy link
Collaborator

MehdiChinoune commented Oct 19, 2022

Why?
Did aws-c-common break ABI with the latest update?

@kou
Copy link
Contributor Author

kou commented Oct 19, 2022

Yes.
URI related codes were moved to aws-c-common from aws-c-io:

@MehdiChinoune
Copy link
Collaborator

package-grokker (https://github.com/msys2/MINGW-packages/actions/runs/3255290437/jobs/5344618607#step:3:64) showed:

mingw-w64-aws-c-http
mingw-w64-aws-c-mqtt
mingw-w64-aws-c-s3
mingw-w64-aws-c-auth
mingw-w64-aws-crt-cpp

@kou
Copy link
Contributor Author

kou commented Oct 20, 2022

I'm sorry but I don't know how to interpret the result...
Could you explain it?

@kou
Copy link
Contributor Author

kou commented Oct 20, 2022

Does it show that these packages don't need to be rebuilt?

@lazka
Copy link
Member

lazka commented Oct 21, 2022

I'm sorry but I don't know how to interpret the result...
Could you explain it?

It shows the packages that should have been rebuilt due to ABI breaks.

Though it's unusual for a package to require rebuilds for a patch update.

@lazka lazka merged commit 988fd61 into msys2:master Oct 21, 2022
@kou kou deleted the aws-c-auth-rebuild branch October 21, 2022 06:24
@kou
Copy link
Contributor Author

kou commented Oct 21, 2022

Ah, thanks. I understand. Then we may need to rebuild mingw-w64-aws-c-http and mingw-w64-aws-c-mqtt too. But they don't have any problem on my environment. They may not use removed APIs.

AWS SDK don't use semantic versioning. So we can't infer ABI compatibility from version number.

lazka added a commit that referenced this pull request Oct 21, 2022
@lazka
Copy link
Member

lazka commented Oct 21, 2022

ok, thanks. I triggered a rebuild anyway, just to be safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants