feat(onUnhandledRequest): allow default behaviour in a custom callback #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 57f6451:
|
…ndledrequest Allow users to fall back to default behaviour for onunhandledrequest if they just want to cover a small number of scenarios, then hand back control to msw addresses mswjs#1080
kettanaito
changed the title
kettanaito
changed the title
kettanaito
force-pushed
the
onunhandledrequest-allow-default-behaviour
branch
from
f55b5de
to
99e3e70
Compare
|
Thanks for making this improvement happen, @JamesZoft! 🎉 I've pushed to your feature branch a few minor changes: renamed onUnhandledRequest(request, print) {
print.error() // or `print.warning()`
}Also added a few integration and E2E tests. Everything looks in order! |
kettanaito
force-pushed
the
onunhandledrequest-allow-default-behaviour
branch
from
99e3e70
to
57f6451
Compare
kettanaito
approved these changes
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to fall back to the default behaviour for
onUnhandledRequestif they just want to cover a small number of scenarios, then hand back control to MSW