fix: implement cookie persistence using tough-cookie (#2206)

.gitignore

@@ -12,6 +12,7 @@ msw-*.tgz
 .husky/_
 .env
 **/test-results
+/test/modules/node/node-esm-tests
 
 # Smoke test temporary files.
 /package.json.copy

package.json

@@ -135,8 +135,8 @@
   "dependencies": {
     "@bundled-es-modules/cookie": "^2.0.0",
     "@bundled-es-modules/statuses": "^1.0.1",
+    "@bundled-es-modules/tough-cookie": "^0.1.6",
     "@inquirer/confirm": "^3.0.0",
-    "@mswjs/cookies": "^1.1.0",
     "@mswjs/interceptors": "^0.29.0",
     "@open-draft/until": "^2.1.0",
     "@types/cookie": "^0.6.0",

src/core/utils/HttpResponse/decorators.ts

@@ -1,9 +1,11 @@
 import statuses from '@bundled-es-modules/statuses'
-import type { HttpResponseInit } from '../../HttpResponse'
 import { Headers as HeadersPolyfill } from 'headers-polyfill'
+import type { HttpResponseInit } from '../../HttpResponse'
 
 const { message } = statuses
 
+export const kSetCookie = Symbol('kSetCookie')
+
 export interface HttpResponseDecoratedInit extends HttpResponseInit {
   status: number
   statusText: string
@@ -38,21 +40,35 @@ export function decorateResponse(
     })
   }
 
-  // Cookie forwarding is only relevant in the browser.
-  if (typeof document !== 'undefined') {
-    // Write the mocked response cookies to the document.
-    // Use `headers-polyfill` to get the Set-Cookie header value correctly.
-    // This is an alternative until TypeScript 5.2
-    // and Node.js v20 become the minimum supported version
-    // and getSetCookie in Headers can be used directly.
-    const responseCookies = HeadersPolyfill.prototype.getSetCookie.call(
-      init.headers,
-    )
-
-    for (const cookieString of responseCookies) {
-      // No need to parse the cookie headers because it's defined
-      // as the valid cookie string to begin with.
-      document.cookie = cookieString
+  const responseCookies = init.headers.get('set-cookie')
+
+  if (responseCookies) {
+    // Record the raw "Set-Cookie" response header provided
+    // in the HeadersInit. This is later used to store these cookies
+    // in cookie jar and return the right cookies in the "cookies"
+    // response resolver argument.
+    Object.defineProperty(response, kSetCookie, {
+      value: responseCookies,
+      enumerable: false,
+      writable: false,
+    })
+
+    // Cookie forwarding is only relevant in the browser.
+    if (typeof document !== 'undefined') {
+      // Write the mocked response cookies to the document.
+      // Use `headers-polyfill` to get the Set-Cookie header value correctly.
+      // This is an alternative until TypeScript 5.2
+      // and Node.js v20 become the minimum supported version
+      // and getSetCookie in Headers can be used directly.
+      const responseCookiePairs = HeadersPolyfill.prototype.getSetCookie.call(
+        init.headers,
+      )
+
+      for (const cookieString of responseCookiePairs) {
+        // No need to parse the cookie headers because it's defined
+        // as the valid cookie string to begin with.
+        document.cookie = cookieString
+      }
     }
   }