fix(ClientRequest): spread object args to support "follow-redirects" #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
commented
Mar 30, 2024
| @@ -210,7 +210,7 @@ export function normalizeClientRequestArgs( | |||
| // Handle a given "RequestOptions" object as-is | |||
| // and derive the URL instance from it. | |||
| else if (isObject(args[0])) { | |||
| options = args[0] as any | |||
| options = { ... args[0] as any } | |||
|
@mikicho, thanks for fixing this! Can you please give this a quick review to be sure I moved all the changes correctly? |
kettanaito
commented
Mar 30, 2024
| @@ -274,7 +274,7 @@ it('handles [RequestOptions, callback] input', () => { | |||
| expect(url.href).toEqual('https://mswjs.io/resource') | |||
|
|
|||
| // Request options must be preserved. | |||
| expect(options).toEqual(initialOptions) | |||
| expect(options).toMatchObject(initialOptions) | |||
There was a problem hiding this comment.
With the fix, the actual options object will contain more things, like _defaultAgent. I suppose I good thing!
|
LGTM |
kettanaito
merged commit 3348dd7
into
feat/yet-another-socket-interceptor
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.