Repository navigation
Review bot: run only on /review - #961
Conversation
The review bot ran a light review automatically whenever a contributor opened, reopened or readied a non-draft PR. Reviews now run only when someone asks for one with `/review`, `/review thorough` or `/review continue`, so the workflow's only trigger is issue_comment. Dropping pull_request_target also drops the `ai-review-thorough` label path; `/review thorough` does the same thing. With every run now a request, an out-of-credit refusal always gets the one-line reply, and the checkout no longer needs allow-unsafe-pr-checkout, whose guard applies only to pull_request_target and workflow_run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Automated review🟡 1 P2 on Outside the diff
Description
What the review checked
Advisory, not a merge gate. Rules: |
vasilevklart
left a comment
There was a problem hiding this comment.
lgtm, i think it is nice change so we can just request on demand.. .github/review/review-prompt.md:73 still says “runs once when a contributor opens or readies a non-draft PR”, it should now just say it runs on each /review
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…split-2-speech-language Brings #858's deletion of NodeSubmodule.splits_heads in favour of RaggedAttentionConfig.shard_over_sp, and origin/main's #810 (per-node dtype and autocast), #961 and #931 (Rust loop-back fix). The compile-region warm-up now reads the node's resolved dtype by name and names the node in its autocast scope. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The review bot no longer runs on its own. Opening, reopening or readying a PR, or pushing to it, never starts a review. It runs only when someone comments
/review,/review thoroughor/review continue, with the same permission checks as before.Reviews are now on demand, so nothing is spent on PRs nobody asked to have reviewed.
Changes
claude-review.yml: the only trigger isissue_comment. Thepull_request_targettrigger is gone, and so is theai-review-thoroughlabel, which needed it./review thoroughdoes the same thing. The/reviewmatching in the job'sif, the preflight's write-access check, the author's self-serve/review,skip-ai-review, concurrency and permissions are unchanged.allow-unsafe-pr-checkoutis removed from the PR checkout. That actions/checkout guard applies only topull_request_targetandworkflow_runevents, and the reviewer still only reads the PR's tree..github/review/README.mdandCONTRIBUTING.mdnow say it runs only on/review, and the text about automatic runs and the label is gone.A stacked PR whose base branch still has an old copy of the workflow can still get an automatic review from that copy until the base branch picks up this change, because
pull_request_targetruns the base branch's workflow file.How it was checked
pull_request_target(opened,reopened,ready_for_review,labeled) andissue_comment(created). After:issue_comment(created) only.yaml.safe_loadparses the file, and actionlint reports nothing (run without shellcheck)./reviewafter merge exercises it.🤖 Generated with Claude Code