Repository navigation
[5/N] docs: accelerator graph documentation and terminology - #475
Open
yao-matrix wants to merge 16 commits into
Open
yao-matrix wants to merge 16 commits into
yao-matrix wants to merge 16 commits into
Conversation
yao-matrix
marked this pull request as ready for review
October 19, 2026 16:53
yao-matrix
force-pushed
the
yao-matrix/pr262-accelerator-graph-wording
branch
from
October 19, 2026 17:21
7c35e6e to
cea9f89
Compare
Contributor
Author
|
@NSagan271 and @merceod, pls help review, this PR only includes doc & code-comments changes, thx. |
Contributor
Author
|
@NSagan271 @merceod gentle ping, thx. The PR failure is for timeout, seems not relevant to this PR. |
Contributor
Author
|
@NSagan271 , gentle ping, thx |
Contributor
Author
|
@NSagan271 , gentle ping, thx |
Contributor
Author
|
@NSagan271 @merceod , gentle ping, thx |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is a doc & code-comment-only PR. No code changes are included.
Follow-up to #262, which is now merged. Rebased the accumulated documentation/comment changes onto upstream. Latest documentation head:
d4d8794f; merged upstream maineceea1be.Summary
Move broader documentation and CUDA-to-accelerator comment rewording out of [4/N] extend CUDA-specific graph API to pytorch's accelerator graph backend, to make graph supported on Intel GPU (XPU) #262, including wording in helpers, tests, and YAML configs. Matching environment-variable rows, essential explanations of new abstractions, and repository skill guidance (
AGENTS.mdand.claude/skills/) remain in [4/N] extend CUDA-specific graph API to pytorch's accelerator graph backend, to make graph supported on Intel GPU (XPU) #262.Use accelerator graph terminology and update graph API references in comments and docstrings, including main's new LTX-2.5 shape buckets and combined-walk documentation.
Define
CG/cg_as "captured graph" in the shared resource module.Correct Pi05 capture documentation: batch size 1, eager capture before forward compilation, and the actual runner/static-buffer contract. Correct Z-Image's module-level
DummyRowPoolreference.Document accelerator graph APIs, model options, and environment variables. Runtime code, configuration values, and shell commands are unchanged.
Correct Qwen3-Omni code predictor input shapes, persistent KV cache lifecycle, and Triton RoPE description; document V-JEPA2 rollout/MPC wrappers and declared KV resources; remove references to deleted engine/cache classes.
Clarify Qwen3-TTS CodePredictor cache ownership, shared-engine dispatch and resource declarations, and the worker's generic device events on the execution stream.
Finish the CUDA-to-accelerator graph wording in Kokoro's bucket documentation and Qwen3-Omni's static-output docstring.
Verification (
a3a1c491)uv tool run ruff check .andgit diff --check upstream/main: passed.mstar/model/cosmos3/tests/test_denoise_compile.pyfailed because this environment lacksdiffusers; the other targeted modules were subsequently run successfully.AGENTS.mdand.claude/skills/are identical to main.AI assistance was used for merge resolution and verification.
Wording follow-up (
d4d8794f)docs/models.rstchanged.uv tool run ruff check .andgit diff --check: passed. Runtime tests were not rerun for these four prose edits; the merge validation above remains recorded ata3a1c491.