Repository navigation
Conversation
merceod
force-pushed
the
users/atindra/pr-41-v7-zimage
branch
from
November 1, 2026 15:06
7c0959f to
51306da
Compare
amd-flashinfer 0.6.18+amd.1's generated AITER prefill config names __hip_bfloat16 before anything declares it, because the JIT's -DUSE_ROCM=1 turns off the hip_bf16.h include in torch's BFloat16.h. Every bf16 model on FlashInfer's auto backend dies at setup with a ninja log. Give the JIT the header through FLASHINFER_EXTRA_CUDAFLAGS on ROCm; 0.6.18+amd.2 includes it itself.
… pool's workers The pool is built under a config patch at the top of warmup, since the setting is part of a graph's cache key and an env default would recompile everything a golden cache holds.
A submodule can compile at load, and klein does, so the pool built at the top of warmup came too late: the first compile had already built it under inductor's defaults, quiesce included. The call moves to the top of EngineManager.build, so no model has to ask for it.
…forward alone Rebase note: the limit also scales with main's step schedule, whose bf16 twin compiles the same code objects.
Window J: table off ties it within 1 % at c=1 and inside the noise at c=16. The RoPE in real arithmetic, the 1344x768 capture, capture batch sizes 1-8 and the recompile limit stay.
merceod
force-pushed
the
users/atindra/pr-41-v7-zimage
branch
from
November 5, 2026 17:52
51306da to
8dd259a
Compare
merceod
changed the base branch from
users/atindra/pr-40-v5b-step-fp8
to
users/atindra/pr-33-v4-fp8-dit
November 5, 2026 17:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1099 (pr-33-v4-fp8-dit). Picks the commits of #1101 first; they drop out of this diff as those merge.
Why
z_image_turbo trailed vllm-omni on MI325X: in window J the tip served 1.068 / 1.149 images/s at c=1 / c=16, vllm-omni 1.090 / 1.149 in window H. Two things cost it. 1344x768, half the request set, wasn't captured and ran eager, 955 ms an image against 920 for captured 1024x1024. And c=16 steps average 5.7 rows, so every batch size up to 8 needs a graph.
What changed
Stacked on #1099 with #1101 picked first (it brings #1100).
tuned_linears's 54-size hipBLASLt table for the DiT GEMMs comes in and goes out again (eaefc6e, 4749ed2), so the net diff has no table; 4749ed2 removes dit_linear.json, the config line, its docs and its GPU test.Verification
Not in this PR
Rebased onto main
Rebased onto main (ff7819d, 2026-11-05); 6 of its 10 commits. Not here any more:
z_image: rotate q/k in real arithmetic so Inductor fuses it with the norms(b7511c2) is on main as main's qk_norm_rope (#860, #972), the same goal by another route;z_image: text encoder can pad to the caption bucket instead of 512(0512896) is dropped again by f087716 in this range (no served gain), so neither is here; 1762ce8, the tuned hipBLASLt table mechanism (opt-in per model) is removed again by 4749ed2 in this range (window J: the table off ties); only the table's own add and removal stay;z_image: drop the text padding option, no served gain to justify it(f087716) had nothing left to remove once 0512896 was skipped. The MI325X numbers here were measured on the AMD line before its rebase; the rebased line read level on the Qwen3-TTS, Qwen3-Omni, Qwen3.5 mtp2 and FLUX.2 klein smoke rows, and -8.7 % on the Qwen3.5-0.8B text c=64 row, which waits on the twin-slot re-port (phase 2).