Text analytics Jonathan feedback updates

.github/CODEOWNERS

@@ -32,6 +32,7 @@
 /eng/code-quality-reports/          @mssfang @JonathanGiles
 /eng/jacoco-test-coverage/          @srnagar @JonathanGiles
 /eng/spotbugs-aggregate-report/     @srnagar @JonathanGiles
+/parent/                            @JimSuplizio
 
 /**/tests.yml   @danieljurek
 /**/ci.yml      @mitchdenny

api-specs.json

@@ -160,6 +160,10 @@
     "source": "specification/machinelearningservices/resource-manager/readme.md",
     "args": "--multiapi --fluent"
   },
+  "maintenance/resource-manager": {
+    "source": "specification/maintenance/resource-manager/readme.md",
+    "args": "--multiapi --fluent"
+  },
   "mariadb/resource-manager": {
     "source": "specification/mariadb/resource-manager/readme.md",
     "args": "--multiapi --fluent"

eng/code-quality-reports/src/main/resources/checkstyle/checkstyle-suppressions.xml

@@ -47,6 +47,9 @@
   <suppress checks="MethodName" files="SymmetricEncryptionAlgorithm.java"/>
   <suppress checks="MethodName" files="RsaSignature.java"/>
 
+  <!-- empty Enum Singleton Pattern -->
+  <suppress checks="NoWhitespaceBefore" files="Messages.java"/>
+
   <!-- Public API already released with incorrect constant variable naming -->
   <suppress checks="ConstantName" files="AlgorithmResolver.java"/>
   <suppress checks="ConstantName" files="AmqpErrorCode.java"/>
@@ -128,6 +131,9 @@
   <!-- Suppress LineLength for Track 1 libraries. -->
   <suppress checks="LineLength" files=".*[/\\]com[/\\]microsoft[/\\]"/>
 
+  <!-- Suppress LineLength for i18n message properties -->
+  <suppress checks="LineLength" files="messages.properties"/>
+
   <!-- Don't apply custom Checkstyle rules to files under checkstyle package. -->
   <suppress checks="com\.azure\.tools\.checkstyle\.checks\..+" files=".*[/\\]tools[/\\]checkstyle[/\\].*"/>
 
@@ -188,6 +194,8 @@
   <suppress checks="com.azure.tools.checkstyle.checks.GoodLoggingCheck" files=".*[/\\]core[/\\]test[/\\].*\.java"/>
   <!-- Class has static methods which using static logger instance, issue link: https://github.com/Azure/azure-sdk-for-java/issues/5137-->
   <suppress checks="com.azure.tools.checkstyle.checks.GoodLoggingCheck" files="CertificateUtil.java"/>
+  <!-- Requires static access to logger to report errors while loading i18n messages (from within a static initializer )-->
+  <suppress checks="com.azure.tools.checkstyle.checks.GoodLoggingCheck" files="Messages.java"/>
 
   <!-- Event Hubs uses AMQP, which does not contain an HTTP response. Returning PagedResponse and Response does not apply. -->
   <suppress checks="com.azure.tools.checkstyle.checks.ServiceClientCheck" files="com.azure.messaging.eventhubs.EventHubClient.java"/>
@@ -235,6 +243,7 @@
   <!-- Allows the SasTokenCredentialPolicy in Implementation -->
   <suppress checks="com.azure.tools.checkstyle.checks.HttpPipelinePolicy" files="com.azure.storage.common.implementation.policy.SasTokenCredentialPolicy.java"/>
   <suppress checks="com.azure.tools.checkstyle.checks.HttpPipelinePolicy" files="com.azure.security.keyvault.secrets.implementation.KeyVaultCredentialPolicy.java"/>
+  <suppress checks="com.azure.tools.checkstyle.checks.HttpPipelinePolicy" files="com.azure.security.keyvault.certificates.implementation.KeyVaultCredentialPolicy.java"/>
   <suppress checks="com.azure.tools.checkstyle.checks.HttpPipelinePolicy" files="com.azure.security.keyvault.keys.implementation.KeyVaultCredentialPolicy.java"/>
 
   <!-- Empty while loop waiting for Reactor stream completion -->

eng/jacoco-test-coverage/pom.xml

@@ -10,7 +10,7 @@
   <parent>
     <groupId>com.azure</groupId>
     <artifactId>azure-client-sdk-parent</artifactId>
-    <version>1.6.0</version> <!-- {x-version-update;com.azure:azure-client-sdk-parent;current} -->
+    <version>1.7.0</version> <!-- {x-version-update;com.azure:azure-client-sdk-parent;current} -->
     <relativePath>../../pom.client.xml</relativePath>
   </parent>
 
@@ -39,7 +39,7 @@
     <dependency>
       <groupId>com.azure</groupId>
       <artifactId>azure-core</artifactId>
-      <version>1.1.0-beta.1</version> <!-- {x-version-update;com.azure:azure-core;current} -->
+      <version>1.1.0</version> <!-- {x-version-update;com.azure:azure-core;current} -->
     </dependency>
     <dependency>
       <groupId>com.azure</groupId>
@@ -49,7 +49,7 @@
     <dependency>
       <groupId>com.azure</groupId>
       <artifactId>azure-core-http-netty</artifactId>
-      <version>1.1.0-beta.1</version> <!-- {x-version-update;com.azure:azure-core-http-netty;current} -->
+      <version>1.1.0</version> <!-- {x-version-update;com.azure:azure-core-http-netty;current} -->
     </dependency>
     <dependency>
         <groupId>com.azure</groupId>
@@ -154,7 +154,7 @@
       <plugin>
         <groupId>org.jacoco</groupId>
         <artifactId>jacoco-maven-plugin</artifactId>
-        <version>${jacoco-maven-plugin.version}</version>
+        <version>0.8.4</version> <!-- {x-version-update;org.jacoco:jacoco-maven-plugin;external_dependency} -->
         <executions>
           <execution>
             <phase>prepare-package</phase>

eng/spotbugs-aggregate-report/pom.xml

@@ -6,7 +6,7 @@
   <parent>
     <artifactId>azure-client-sdk-parent</artifactId>
     <groupId>com.azure</groupId>
-    <version>1.6.0</version> <!-- {x-version-update;com.azure:azure-client-sdk-parent;current} -->
+    <version>1.7.0</version> <!-- {x-version-update;com.azure:azure-client-sdk-parent;current} -->
     <relativePath>../../pom.client.xml</relativePath>
   </parent>
   <modelVersion>4.0.0</modelVersion>
@@ -25,6 +25,7 @@
       <plugin>
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>build-helper-maven-plugin</artifactId>
+        <version>3.0.0</version> <!-- {x-version-update;org.codehaus.mojo:build-helper-maven-plugin;external_dependency} -->
         <executions>
           <execution>
             <id>add-client-source</id>
@@ -82,6 +83,7 @@
       <plugin>
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>build-helper-maven-plugin</artifactId>
+        <version>3.0.0</version> <!-- {x-version-update;org.codehaus.mojo:build-helper-maven-plugin;external_dependency} -->
         <executions>
           <execution>
             <id>add-data-source</id>
@@ -114,6 +116,7 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-javadoc-plugin</artifactId>
+        <version>3.1.1</version> <!-- {x-version-update;org.apache.maven.plugins:maven-javadoc-plugin;external_dependency} -->
         <configuration>
           <!-- Added to override the -snippetpath arg which is not applicable here-->
           <additionalOptions>-maxLineLength 120</additionalOptions>
@@ -141,7 +144,7 @@
         <dependency>
           <groupId>com.azure</groupId>
           <artifactId>azure-core</artifactId>
-          <version>1.1.0-beta.1</version> <!-- {x-version-update;com.azure:azure-core;current} -->
+          <version>1.1.0</version> <!-- {x-version-update;com.azure:azure-core;current} -->
         </dependency>
         <dependency>
           <groupId>com.azure</groupId>
@@ -151,7 +154,7 @@
         <dependency>
           <groupId>com.azure</groupId>
           <artifactId>azure-core-http-netty</artifactId>
-          <version>1.1.0-beta.1</version> <!-- {x-version-update;com.azure:azure-core-http-netty;current} -->
+          <version>1.1.0</version> <!-- {x-version-update;com.azure:azure-core-http-netty;current} -->
         </dependency>
         <dependency>
           <groupId>com.azure</groupId>
@@ -249,7 +252,7 @@
         <dependency>
           <groupId>com.google.code.findbugs</groupId>
           <artifactId>jsr305</artifactId>
-          <version>3.0.2</version>
+          <version>3.0.2</version> <!-- {x-version-update;com.google.code.findbugs:jsr305;external_dependency} -->
           <scope>provided</scope>
         </dependency>
       </dependencies>
@@ -324,7 +327,7 @@
         <dependency>
           <groupId>com.microsoft.azure</groupId>
           <artifactId>azure-servicebus</artifactId>
-          <version>3.1.1</version> <!-- {x-version-update;com.microsoft.azure:azure-servicebus;current} -->
+          <version>3.1.4</version> <!-- {x-version-update;com.microsoft.azure:azure-servicebus;current} -->
         </dependency>
       </dependencies>
       <properties>

eng/versioning/external_dependencies.txt

@@ -0,0 +1,212 @@
+# Format;
+# groupId:artifactId;dependency-version
+com.fasterxml.jackson.core:jackson-annotations;2.10.0
+com.fasterxml.jackson.core:jackson-core;2.10.0
+com.fasterxml.jackson.core:jackson-databind;2.10.0
+com.fasterxml.jackson.dataformat:jackson-dataformat-xml;2.10.0
+com.fasterxml.jackson.datatype:jackson-datatype-jsr310;2.10.0
+com.fasterxml.uuid:java-uuid-generator;3.2.0
+com.github.spotbugs:spotbugs;4.0.0-beta3
+com.github.spotbugs:spotbugs-maven-plugin;3.1.12.2
+com.google.code.gson:gson;2.8.5
+com.google.guava:guava;24.1.1-jre
+com.microsoft.azure:azure-annotations;1.7.0
+com.microsoft.azure:azure-arm-client-runtime;1.6.15
+com.microsoft.azure:azure-client-authentication;1.6.15
+com.microsoft.azure:azure-client-runtime;1.6.15
+com.microsoft.azure:azure-core;0.9.8
+com.microsoft.azure:azure-keyvault-cryptography;1.2.2
+com.microsoft.azure:azure-mgmt-keyvault;1.11.1
+com.microsoft.azure:client-runtime;1.6.15
+com.microsoft.azure:qpid-proton-j-extensions;1.2.1
+com.microsoft.azure:spotbugs-maven-plugin;1.2.1
+com.microsoft.rest:client-runtime;1.6.15
+com.microsoft.rest.v2:client-runtime;2.1.1
+com.squareup.okhttp3:okhttp;4.2.2
+commons-codec:commons-codec;1.13
+io.micrometer:micrometer-core;1.2.0
+io.micrometer:micrometer-registry-azure-monitor;1.2.0
+io.micrometer:micrometer-registry-graphite;1.2.0
+io.netty:netty-buffer;4.1.42.Final
+io.netty:netty-codec-http;4.1.42.Final
+io.netty:netty-codec-http2;4.1.42.Final
+io.netty:netty-handler;4.1.42.Final
+io.netty:netty-handler-proxy;4.1.42.Final
+io.netty:netty-tcnative;2.0.26.Final
+io.netty:netty-tcnative-boringssl-static;2.0.26.Final
+io.netty:netty-transport-native-epoll;4.1.42.Final
+io.netty:netty-transport-native-unix-common;4.1.42.Final
+io.opencensus:opencensus-api;0.24.0
+io.opencensus:opencensus-impl;0.24.0
+io.projectreactor.netty:reactor-netty;0.9.0.RELEASE
+io.projectreactor:reactor-core;3.3.0.RELEASE
+io.reactivex:rxjava;1.2.4
+org.apache.httpcomponents:httpclient;4.3.6
+org.apache.logging.log4j:log4j-api;2.11.1
+org.apache.logging.log4j:log4j-core;2.11.1
+org.apache.qpid:proton-j;0.33.2
+org.asynchttpclient:async-http-client;2.10.4
+org.codehaus.groovy:groovy-eclipse-batch;2.5.8-01
+org.codehaus.groovy:groovy-eclipse-compiler;3.4.0-01
+org.powermock:powermock-api-mockito2;2.0.2
+org.powermock:powermock-module-junit4;2.0.2
+org.slf4j:slf4j-api;1.7.28
+org.slf4j:slf4j-log4j12;1.7.0
+org.slf4j:slf4j-simple;1.7.25
+
+## Test dependency versions
+cglib:cglib-nodep;3.2.7
+com.github.tomakehurst:wiremock-standalone;2.24.1
+com.microsoft.azure:adal4j;1.6.4
+com.microsoft.azure:azure-mgmt-graph-rbac;1.3.0
+com.microsoft.azure:azure-mgmt-keyvault;1.11.1
+com.microsoft.azure:azure-mgmt-resources;1.3.0
+com.microsoft.azure:azure-mgmt-storage;1.3.0
+com.microsoft.azure:azure-storage;8.0.0
+com.microsoft.azure:msal4j;0.5.0-preview
+io.opentelemetry:opentelemetry-api;0.2.0
+io.opentelemetry:opentelemetry-sdk;0.2.0
+io.projectreactor:reactor-test;3.3.0.RELEASE
+junit:junit;4.13-beta-3
+log4j:log4j;1.2.17
+org.assertj:assertj-core;3.11.1
+org.bouncycastle:bcprov-jdk15on;1.60
+org.eclipse.jetty:jetty-http;9.4.11.v20180605
+org.eclipse.jetty:jetty-server;9.4.11.v20180605
+org.hamcrest:hamcrest-all;1.3
+org.hamcrest:hamcrest-library;2.2
+# https://junit.org/junit5/docs/current/user-guide/#running-tests-ide-intellij-idea
+# use 5.4.2 now since Version 5.5.2 as of 11.2019 fails to discover tests 
+# https://youtrack.jetbrains.com/issue/IDEA-223700
+# org.junit:junit-bom;5.4.2 is a pom file that will add its dependencyManagement section to parent pom's which
+# effectively means that each dependency needs to be listed here.
+org.junit.jupiter:junit-jupiter;5.4.2
+org.junit.jupiter:junit-jupiter-api;5.4.2
+org.junit.jupiter:junit-jupiter-engine;5.4.2
+org.junit.jupiter:junit-jupiter-migrationsupport;5.4.2
+org.junit.jupiter:junit-jupiter-params;5.4.2
+org.junit.platform:junit-platform-commons;1.4.2
+org.junit.platform:junit-platform-console;1.4.2
+org.junit.platform:junit-platform-engine;1.4.2
+org.junit.platform:junit-platform-launcher;1.4.2
+org.junit.platform:junit-platform-reporting;1.4.2
+org.junit.platform:junit-platform-runner;1.4.2
+org.junit.platform:junit-platform-suite-api;1.4.2
+org.junit.platform:junit-platform-testkit;1.4.2
+org.junit.vintage:junit-vintage-engine;5.4.2
+org.openjdk.jmh:jmh-core;1.22
+org.openjdk.jmh:jmh-generator-annprocess;1.22
+org.spockframework:spock-core;1.3-groovy-2.5
+org.testng:testng;6.14.3
+uk.org.lidalia:slf4j-test;1.2.0
+
+## Maven Tools versions
+com.azure:sdk-build-tools;1.0.0
+com.beust:jcommander;1.58
+com.google.code.findbugs:jsr305;3.0.2
+com.nimbusds:nimbus-jose-jwt;6.0.1
+com.nimbusds:oauth2-oidc-sdk;6.14
+com.puppycrawl.tools:checkstyle;8.24
+commons-io:commons-io;2.5
+commons-validator:commons-validator;1.6
+io.dropwizard.metrics:metrics-core;4.0.5
+io.dropwizard.metrics:metrics-graphite;4.0.5
+io.dropwizard.metrics:metrics-jvm;4.0.5
+io.reactivex.rxjava2:rxjava;2.2.4
+net.java.dev.jna:jna-platform;5.4.0
+org.apache.commons:commons-collections4;4.2
+org.apache.commons:commons-lang3;3.8.1
+org.apache.commons:commons-text;1.6
+org.apache.maven.plugins:maven-antrun-plugin;1.8
+org.apache.maven.plugins:maven-assembly-plugin;2.2
+org.apache.maven.plugins:maven-checkstyle-plugin;3.1.0
+org.apache.maven.plugins:maven-clean-plugin;3.0.0
+org.apache.maven.plugins:maven-compiler-plugin;3.8.1
+org.apache.maven.plugins:maven-eclipse-plugin;2.8
+org.apache.maven.plugins:maven-failsafe-plugin;2.22.0
+org.apache.maven.plugins:maven-help-plugin;2.1.1
+org.apache.maven.plugins:maven-jar-plugin;3.1.2
+org.apache.maven.plugins:maven-javadoc-plugin;3.1.1
+org.apache.maven.plugins:maven-jxr-plugin;3.0.0
+org.apache.maven.plugins:maven-project-info-reports-plugin;3.0.0
+org.apache.maven.plugins:maven-release-plugin;2.5.3
+org.apache.maven.plugins:maven-resources-plugin;2.4.3
+org.apache.maven.plugins:maven-site-plugin;3.7.1
+org.apache.maven.plugins:maven-source-plugin;3.0.1
+org.apache.maven.plugins:maven-surefire-plugin;3.0.0-M3
+org.apidesign.javadoc:codesnippet-doclet;0.32
+org.codehaus.mojo:build-helper-maven-plugin;3.0.0
+org.codehaus.mojo:exec-maven-plugin;1.2.1
+org.codehaus.mojo:properties-maven-plugin;1.0.0
+org.codehaus.mojo:xml-maven-plugin;1.0
+org.eclipse.jetty:jetty-maven-plugin;9.3.22.v20171030
+org.eclipse.m2e:lifecycle-mapping;1.0.0
+org.jacoco:jacoco-maven-plugin;0.8.4
+org.jacoco:org.jacoco.agent;0.8.4
+org.mockito:mockito-core;3.0.0
+org.nanohttpd:nanohttpd;2.3.1
+
+# External Dependency Exceptions
+# This section is for external dependencies whose versions were different than 
+# what was defined in the parent pom.
+# Format;
+# <some unique identifier, area name preferred>_groupId:artifactId;dependency-version
+
+# This is a unique dependency as it is the only <type>test-jar</type> dependency in the
+# data track. It's also using a SNAPSHOT version which should be disallowed but there is
+# going to be some investigation necessary to find, at the very least, a newer version
+# which is, hopefully, not a SNAPSHOT.
+# sdk\batch\microsoft-azure-batch\pom.xml
+# sdk\keyvault\microsoft-azure-keyvault\pom.xml
+# sdk\keyvault\microsoft-azure-keyvault-extensions\pom.xml
+# sdk\keyvault\microsoft-azure-keyvault-test\pom.xml
+test_jar_com.microsoft.azure:azure-mgmt-resources;1.3.1-SNAPSHOT
+
+# sdk\applicationinsights\microsoft-azure-applicationinsights-query\pom.xml
+applicationinsights_com.microsoft.azure:azure-arm-client-runtime;1.6.3
+applicationinsights_com.microsoft.azure:azure-client-runtime;1.6.3
+applicationinsights_com.microsoft.azure:azure-client-authentication;1.6.3
+
+# everything under sdk\cosmos
+cosmos_org.mockito:mockito-core;1.10.19
+cosmos_com.google.guava:guava;27.0.1-jre
+cosmos_io.dropwizard.metrics:metrics-core;4.1.0
+cosmos_io.dropwizard.metrics:metrics-jvm;4.1.0
+cosmos_io.dropwizard.metrics:metrics-graphite;4.1.0
+
+# sdk\eventgrid\microsoft-azure-eventgrid\pom.xml
+eventgrid_com.microsoft.azure:azure-client-runtime;1.5.0
+eventgrid_com.microsoft.azure:azure-client-authentication;1.5.0
+eventgrid_commons-io:commons-io;2.6
+
+# sdk\eventhubs\microsoft-azure-eventhubs-eph\pom.xml
+# sdk\eventhubs\microsoft-azure-eventhubs-extensions\pom.xml
+eventhubs_com.microsoft.azure:msal4j;0.4.0-preview
+
+# sdk\keyvault\microsoft-azure-keyvault-extensions\pom.xml
+keyvault_org.mockito:mockito-core;1.10.19
+# sdk\keyvault\microsoft-azure-keyvault-test\pom.xml
+keyvault_com.microsoft.azure:azure-storage;4.4.0
+
+# sdk\loganalytics\microsoft-azure-loganalytics\pom.xml
+loganalytics_com.microsoft.azure:azure-arm-client-runtime;1.6.3
+loganalytics_com.microsoft.azure:azure-client-authentication;1.6.3
+loganalytics_com.microsoft.azure:azure-client-runtime;1.6.3
+
+# sdk\mediaservices\microsoft-azure-media\pom.xml which hasn't been released for 2 years
+# all of these unique references below are listed here because they're old, some are over 10 years old
+media_javax.xml.bind:jaxb-api;2.2.7
+media_javax.inject:javax.inject;1
+media_javax.mail:mail;1.4.5
+media_com.sun.jersey:jersey-client;1.19
+media_com.sun.jersey:jersey-json;1.19
+media_commons-logging:commons-logging;1.1.1
+media_io.jsonwebtoken:jjwt;0.5.1
+media_org.mockito:mockito-all;1.9.0
+media_com.microsoft.azure:adal4j;1.2.0
+
+# sdk\servicebus\microsoft-azure-servicebus\pom.xml
+servicebus_com.microsoft.azure:azure-client-authentication;1.6.7
+
+# sdk\storage\azure-storage-blob-cryptography\pom.xml
+storage_com.microsoft.azure:azure-storage;8.4.0