Update Priority Queue Cloud Pattern #122

skabou · 2024-03-13T19:25:02Z

Update to .NET 8.0
Updated README

Update to .NET 8.0 Updated README

ckittel

Summary:

Use Entra ID
Use new Azure SDK dependency injection model
How do we get this to not just be a pub-sub example?
Use bicep for the azure resource deployments

That third item is worrying me a bit, not sure how best to proceed. Would be glad to talk it over w/ ya!

ckittel · 2024-03-14T13:10:04Z

priority-queue/Readme.md

+   RESOURCE_GROUP_NAME=rg-priority-queue
+   az group create -n $RESOURCE_GROUP_NAME -l eastus2
+   ```
+1. Provision a Service Bus messaging namespace.


For the Service Bus deployment, can you just wrap this all in a simple bicep file to do a one-step deployment? You can still use the command to get the connection string at the end.

ckittel · 2024-03-14T13:11:19Z

priority-queue/Readme.md

+
+1. Set the `PriorityQueueSender` project as startup. 
+1. Press F5 in Visual Studio to start running the example. The function will begin sending messages to the topic every 30 seconds.


Might be good to mention that it sends a mix of high and low priority messages.

ckittel · 2024-03-14T13:14:59Z

priority-queue/Readme.md

+1. Edit the `local.settings.json` file for each project set the value of `ServiceBusConnectionString` to the **SERVICE_BUS_CONNECTION_STRING** retained from earlier.
+
+1. Set the `PriorityQueueSender` project as startup. 


can we just func start this? Then we wouldn't need Visual Studio installed (we're getting to the point that we either just use CLI or VSCode -- Visual Studio is "a bit much" for samples.

ckittel · 2024-03-14T13:15:33Z

priority-queue/Readme.md

+1. Press F5 in Visual Studio to start the execution of the consumer function.
+1. In the Azure Functions Core Tools Console, you can view the diagnostic information generated by statements in the code.


Same here, if we have the core tools installed then func start should work for us.

ckittel · 2024-03-14T13:37:07Z

priority-queue/PriorityQueueSender/Program.cs

+  .ConfigureFunctionsWorkerDefaults()
+  .ConfigureAppConfiguration((hostingContext, config) =>
+  {
+      config.AddJsonFile("local.settings.json", optional: true, reloadOnChange: true);
+  })
+  .ConfigureServices(services =>
+  {
+      var configuration = services.BuildServiceProvider().GetRequiredService<IConfiguration>();
+
+      services.AddSingleton(configuration);
+
+      services.AddSingleton<ServiceBusClient>(sp =>
+      {
+          var connectionString = configuration.GetValue<string>("ServiceBusConnectionString");
+          return new ServiceBusClient(connectionString);
+      });
+  })
+  .Build();


Can this get converted to:

services.AddAzureClients(cb => { cb.AddServiceBusClient(...) });

https://learn.microsoft.com/azure/azure-functions/dotnet-isolated-process-guide?tabs=linux#register-azure-clients -- The PG is trying to get folks to use this model for Azure SDK clients intead of the custom approach like you have here.

ckittel · 2024-03-14T13:43:20Z

priority-queue/PriorityQueueConsumerHigh/PriorityQueueConsumerHighFn.cs

+        public PriorityQueueConsumerHighFn(ILogger<PriorityQueueConsumerHighFn> logger)
+        {
+            _logger = logger;
+        }


Can you convert to automatic constructor?

ckittel · 2024-03-14T13:43:57Z

priority-queue/PriorityQueueConsumerHigh/PriorityQueueConsumerHigh.csproj

    <None Update="local.settings.json">
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
      <CopyToPublishDirectory>Never</CopyToPublishDirectory>
    </None>
  </ItemGroup>
-</Project>
+  <ItemGroup>
+    <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.Http" Version="3.1.0" />


Is Http a requirement for something here? I thought that was only for Http triggers?

Agree. Addressed/removed.

ckittel · 2024-03-14T13:44:11Z

priority-queue/PriorityQueueConsumerLow/PriorityQueueConsumerLow.csproj

    <None Update="local.settings.json">
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
      <CopyToPublishDirectory>Never</CopyToPublishDirectory>
    </None>
  </ItemGroup>
-</Project>
+  <ItemGroup>
+    <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.Http" Version="3.1.0" />


Same question on Http here

Agree. Addressed/removed.

ckittel · 2024-03-14T13:44:27Z

priority-queue/PriorityQueueConsumerLow/PriorityQueueConsumerLowFn.cs

+        public PriorityQueueConsumerLowFn(ILogger<PriorityQueueConsumerLowFn> logger)
+        {
+            _logger = logger;
+        }


Can you convert to automatic constructor?

ckittel · 2024-03-14T13:53:48Z

priority-queue/Readme.md

+1. Set the `PriorityQueueSender` project as startup. 
+1. Press F5 in Visual Studio to start running the example. The function will begin sending messages to the topic every 30 seconds.
+1. Stop the execution, change the startup project to either the `PriorityQueueConsumerHigh` or `PriorityQueueConsumerLow`.


I'm not seeing how running this locally is really showing priority queues. Since both appear to be doing equal processing. There really isn't even any host.json settings to help show (e.g. maxConcurrentSessions only works for session-based access and maxMessageBatchSize only works for array input bindings). I know when deployed to Azure you can tweak instance count, but the steps here don't really seem to match what is stated at the start of the page. Maybe this sample should only have a "deploy to azure" approach so that this is actually demonstrating the pattern? Right now, it's just a pub-sub processing demo.

@skabou - what did we say next steps were about this?

@ckittel - I have a new version in the works (deploys via bicep file) - Trying to get the PR in before the end of the month. My concern is the example is still "more or less the same" as to what is there - Essentially two pub subs, one for high priority, and one for low priority. If we don't think publishing a demo of that is worthwhile then I could scrap the code portion.

If it's an implementation of the pattern as we have it documented/described, I think it will be useful. If you don't feel though it's an implementation of the pattern, then we need to re-evaluate for sure. I think if your new version does a deploy to azure for sure, then we can show the pattern very clearly with the scale-out settings.

I do think it's still worthwhile to demonstrate.

* Improvements. Bicep file. Settings. Moved to managed identity. Run func start * Removing VS requirement * deleting any --------- Co-authored-by: Federico Arambarri <v-fearam>

Update Priority Queue Cloud Pattern

617a48f

Update to .NET 8.0 Updated README

skabou requested a review from ckittel March 13, 2024 19:55

skabou force-pushed the priority-queue-update branch from c57c76c to 617a48f Compare March 13, 2024 20:24

ckittel requested changes Mar 14, 2024

View reviewed changes

Priority Queue Update (To branch) (#160)

ea84f2a

* Improvements. Bicep file. Settings. Moved to managed identity. Run func start * Removing VS requirement * deleting any --------- Co-authored-by: Federico Arambarri <v-fearam>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Priority Queue Cloud Pattern #122

Update Priority Queue Cloud Pattern #122

skabou commented Mar 13, 2024

ckittel left a comment

ckittel Mar 14, 2024

ckittel Mar 14, 2024

ckittel Mar 14, 2024 •

edited

Loading

ckittel Mar 14, 2024

ckittel Mar 14, 2024

ckittel Mar 14, 2024

skabou Mar 14, 2024

ckittel Mar 14, 2024

skabou Mar 14, 2024

ckittel Mar 14, 2024

skabou Mar 14, 2024

ckittel Mar 14, 2024

skabou Mar 14, 2024

ckittel Mar 14, 2024

ckittel Apr 26, 2024

skabou Apr 26, 2024 •

edited

Loading

ckittel Apr 26, 2024

skabou Apr 26, 2024


		1. Set the `PriorityQueueSender` project as startup.
		1. Press F5 in Visual Studio to start running the example. The function will begin sending messages to the topic every 30 seconds.

		1. Edit the `local.settings.json` file for each project set the value of `ServiceBusConnectionString` to the SERVICE_BUS_CONNECTION_STRING retained from earlier.

		1. Set the `PriorityQueueSender` project as startup.

		1. Press F5 in Visual Studio to start the execution of the consumer function.
		1. In the Azure Functions Core Tools Console, you can view the diagnostic information generated by statements in the code.

Update Priority Queue Cloud Pattern #122

Are you sure you want to change the base?

Update Priority Queue Cloud Pattern #122

Conversation

skabou commented Mar 13, 2024

ckittel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ckittel Mar 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skabou Apr 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ckittel Mar 14, 2024 •

edited

Loading

skabou Apr 26, 2024 •

edited

Loading