Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace starter github workflow with dedicated repo reference #348

Merged
merged 5 commits into from
Sep 16, 2022

Conversation

ckittel
Copy link
Member

@ckittel ckittel commented Sep 16, 2022

The AKS ALZ team has been working for a while to build out a more comprehensive story around automation of the AKS baseline. They are ready to GA it. This PR replaces our little "starter" with links to their full documentation. They are also going to be publishing this to Microsoft Learn, so when that happens, we'll be updating these links to that URL instead.

@ckittel
Copy link
Member Author

ckittel commented Sep 16, 2022

Please review @MattLeach25 and @bahramr. For whatever reason, I can't add you as actual reviewers -- /shrug

Copy link
Contributor

@hallihan hallihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few phrasing updates suggested

12-cleanup.md Outdated Show resolved Hide resolved
12-cleanup.md Outdated Show resolved Hide resolved
01-prerequisites.md Outdated Show resolved Hide resolved
ckittel and others added 2 commits September 16, 2022 12:45
Co-authored-by: Rick Hallihan <[email protected]>
@ckittel
Copy link
Member Author

ckittel commented Sep 16, 2022

@hallihan - Thank you, good additional word smithing and style changes. I applied all your feedback as-is (but changed the docs.microsoft.com link to learn.microsoft.com)

Copy link
Contributor

@hallihan hallihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ckittel
Copy link
Member Author

ckittel commented Sep 16, 2022

Just got approval from @bahramr. Going to merge. GitHub Workflow is Dead. Long Live the GitHub Workflow.

@ckittel ckittel merged commit 73d9b1f into main Sep 16, 2022
@ckittel ckittel deleted the aks-baseline-automation-reference branch September 16, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants