-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add "-mincov" flag option (Issue #19) #20
Conversation
I think the PR passes the CI. $ golangci-lint run
go-carpet.go:7:2: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
"io/ioutil"
^
utils_test.go:4:2: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
"io/ioutil"
^ Do you want me to fix this in the PR as well? |
@KEINOS sorry for delay.
better to fix it in separated pr, or i can fix it later |
I agree. Let's have them in a separate PR! |
also i've fixed |
8770d9e
to
5e4a32a
Compare
Rebased to the PR. How about now? |
Filtering in `getCoverForDir()` is enough.
@KEINOS thanks for contributing! |
Please release the changes when you got time. The |
@msoap Thank you! Now it works 👍 ! |
Feature fix of issue #19