Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KnownTypePolymorhicMessagePackSerializer error message improvement #95

Closed
thomas-joiner opened this issue Jul 8, 2015 · 1 comment
Closed
Labels
enhancement Requires or request to feature enhancement

Comments

@thomas-joiner
Copy link

This applies to release 0.6.0-Beta4.

I ran into an issue when using KnownTypes. In the end, the issue ended up being that I was using [MessagePackKnownType] instead of [MessagePackKnownCollectionItemType]. The error message that I received was:

System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at MsgPack.Serialization.Polymorphic.KnownTypePolymorhicMessagePackSerializer`1.PackToCore(Packer packer, T objectTree)
[...]

It would have been nice to know what key it was looking up to make figuring out what the issue was easier.

Also, the typo in the class name should probably be fixed.

@yfakariya yfakariya added the enhancement Requires or request to feature enhancement label Jul 20, 2015
@yfakariya
Copy link
Member

Fixed in 0.6.0-beta5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requires or request to feature enhancement
Projects
None yet
Development

No branches or pull requests

2 participants