Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generating Serializers with EnumSerializationMethod.ByUnderlyingValue #102

Closed
Tinche opened this issue Jul 30, 2015 · 3 comments
Closed

Generating Serializers with EnumSerializationMethod.ByUnderlyingValue #102

Tinche opened this issue Jul 30, 2015 · 3 comments
Labels
bug Detected as bug

Comments

@Tinche
Copy link

Tinche commented Jul 30, 2015

Hi,

I'm using MsgPack with Unity on iOS, so I'm trying to use pregeneration of serializers (like described in https://github.com/msgpack/msgpack-cli/wiki/Xamarin-and-Unity#generate-serializers-in-advance). However, my enum serializers get generated with EnumSerializationMethod.ByName, instead of by underlying value. It doesn't look like SerializerCodeGenerationConfiguration has an option for this; is there anything that can be done?

Cheers.
@yfakariya yfakariya added the bug Detected as bug label Aug 1, 2015
@yfakariya
Copy link
Member

I forgot it... Thank you for reporting!

@yfakariya yfakariya added question bug Detected as bug and removed bug Detected as bug question labels Aug 1, 2015
yfakariya added a commit that referenced this issue Aug 2, 2015
@yfakariya
Add EnumSerializationMethod support to generator. Issue #102.
29c5166 
* Add support for default EnumSerializationMethod value specification via configuration.
* Add constructor overloads taking EnumSerializationMethod explicitly to serializer code.
* Add constructor overloads using default EnumSerializationMethod implicitly to serializer assembly.
* Fix TracingILGenerator bugs when chained constructor is generated.
@yfakariya
Copy link
Member

Fixed in 0.6.0.

@Tinche
Copy link
Author

Tinche commented Aug 16, 2015

Excellent, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Detected as bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yfakariya @Tinche