Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataloader, no grad scope and auto gpu detection #47

Merged
merged 8 commits into from
Oct 8, 2020

Conversation

hadaev8
Copy link
Contributor

@hadaev8 hadaev8 commented Oct 3, 2020

Based on this pr #9
Gives me around x3 speed gain compared to vanilla.

Copy link
Owner

@mseitzer mseitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good to me, I only have some small changes that would be good to have.

pytorch_fid/fid_score.py Outdated Show resolved Hide resolved
pytorch_fid/fid_score.py Outdated Show resolved Hide resolved
pytorch_fid/fid_score.py Show resolved Hide resolved
pytorch_fid/fid_score.py Outdated Show resolved Hide resolved
@hadaev8
Copy link
Contributor Author

hadaev8 commented Oct 6, 2020

Please verify my matrix population.
It should work as intended now.
But I did too many mistakes.

pytorch_fid/fid_score.py Outdated Show resolved Hide resolved
@mseitzer mseitzer merged commit 4d7695b into mseitzer:master Oct 8, 2020
@mseitzer
Copy link
Owner

mseitzer commented Oct 8, 2020

Merged it. Thank you for the contribution!

@hadaev8
Copy link
Contributor Author

hadaev8 commented Oct 8, 2020

Thanks you for this repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants