Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the python analysis paths for ROS #795

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Conversation

dthelegend
Copy link

@dthelegend dthelegend commented Oct 1, 2022

Noticed while creating a dev container environment for ROS that the settings that are auto-created by the extension are wrong. I have renamed them here to match the current python language server settings https://code.visualstudio.com/docs/python/settings-reference#_python-language-server-settings

EDIT: Correction, the paths were not wrong, simply only the autocomplete paths are included, but not the analysis paths for the linter, leading to a lot of squiggles in my vscode

@dthelegend dthelegend requested a review from a team as a code owner October 1, 2022 22:12
@ghost
Copy link

ghost commented Oct 3, 2022

CLA assistant check
All CLA requirements met.

@dthelegend dthelegend changed the title Rename the python autocomplete paths Add the python analysis paths for ROS Oct 3, 2022
Copy link
Member

@ooeygui ooeygui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR - this looks great!

@dthelegend
Copy link
Author

dthelegend commented Oct 10, 2022

No worries! I'm doing Hacktoberfest this year, so if you could, before it's merged, could you mark it with the HACKTOBERFEST-ACCEPTED label? It's not really important though.

@ooeygui
Copy link
Member

ooeygui commented Oct 10, 2022

Thanks for the PR!

If you want to add another PR with a Doc on how to use this, I would appreciate and prioritize that as well.

Copy link

@IoTDan IoTDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants