Allow customization of build tool tasks #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank @anton-matosov! Can you rebase to reduce the noise on the diff view? |
|
Definitely. my bad |
Add `args` parameter to all build tool tasks that allows customization in the workspaces's tasks.json by users Implement generic task of `ros` type Add `roscore` and `roslaunch` commands using `ros` task that allows user to run and customize them in `tasks.json` Add `roscore and `roslaunch` problem matchers that allow corresponding tasks to run in background
anton-matosov
force-pushed
the
catkinArgs
branch
from
5d75759 to
b0dcf8d
Compare
anton-matosov
commented
Oct 3, 2020
| @@ -11,6 +11,5 @@ | |||
| "search.exclude": { | |||
| "out": true // set this to false to include "out" folder in search results | |||
| }, | |||
| "typescript.tsdk": "./node_modules/typescript/lib", // we want to use the TS server from our node_modules folder to control its version | |||
| "python.pythonPath": "C:\\opt\\python27amd64\\python.exe" | |||
| "typescript.tsdk": "./node_modules/typescript/lib" | |||
There was a problem hiding this comment.
This is the automatic upgrade of settings by corresponding vscode extensions
|
@anton-matosov, LGTM. Is it ready for merge too? |
ooeygui
reviewed
Oct 19, 2020
|
I'm testing this on Windows. @anton-matosov can you update your branch so that the PR is in sync? |
|
Merged in latest master and updated docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #305
Add args parameter to all build tool tasks that allows customization in the workspaces's tasks.json by users
Implement generic task named
rosAdd
roscoreandroslaunchcommands usingrostask that allows user to run and customize them in tasks.json