-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle preLaunch task explicitly #304
Handle preLaunch task explicitly #304
Conversation
While fixing #129 I have found that switching to resolveDebugConfigurationWithSubstitutedVariables handles preLaunchTask correctly and gives variables resolution. So I have revetred explicit handling of the preLaunchTask and only left changes for handling env reload and suppression of the debug adapter startup |
Wow! Thank you for the contribution! |
Thanks for your contribution! |
Fixes #166
Fixes #129
Switch to
resolveDebugConfigurationWithSubstitutedVariables
in theDebugConfigurationProvider
which provides automatic handling of thepreLaunch
task (#166) as well as variables expansion in launch config (#129).Stop returning
config
from the resolvers. This fixes allows to not even start debug adapter, which we terminate right away anyways. Moreover, it fixes fairly often race condition in vscode.debugger that results in re-sending same request 5-6 times. This is most likely caused by the new debugger requests spawning from the debugger request handler.Implement await for the extension.env in launch and attach requests for the case if reload have been triggered in the midst of the request processing. That happens in 100% of cases if
preLaunch
task runscatkin make/build