Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: domain apis #69

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Conversation

mcarey1590
Copy link

Copy link

mergify bot commented Jan 12, 2025

Welcome to our open-source project! 💘

@mrz1836 mrz1836 added feature Any new significant addition update General updates labels Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 50.66667% with 37 lines in your changes missing coverage. Please review.

Project coverage is 87.08%. Comparing base (1806d09) to head (90998cb).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
domains.go 50.66% 37 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   91.31%   87.08%   -4.24%     
==========================================
  Files          13       14       +1     
  Lines         645      720      +75     
==========================================
+ Hits          589      627      +38     
- Misses         48       85      +37     
  Partials        8        8              
Flag Coverage Δ
unittests 87.08% <50.66%> (-4.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
domains.go 50.66% <50.66%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1806d09...90998cb. Read the comment docs.

@mrz1836 mrz1836 merged commit 6adcfc0 into mrz1836:master Jan 13, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Any new significant addition update General updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants