Skip to content

Add comms logger tests and missing comms_dict attribute to CommsLogger #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrwyattii merged 1 commit into from
Apr 20, 2023
Merged

Add comms logger tests and missing comms_dict attribute to CommsLogger #1

mrwyattii merged 1 commit into from
Apr 20, 2023

Conversation

@Quentin-Anthony
Copy link

@Quentin-Anthony Quentin-Anthony commented Mar 14, 2023 •
edited
Loading

I've added two tests:

  1. TestCommsLoggingOverhead ensures the overhead of logging a comms call is low
  2. TestNumLoggingCalls ensures that every comms call is printed to the log

@Quentin-Anthony Quentin-Anthony mentioned this pull request Mar 14, 2023
Open
2 tasks
@mrwyattii mrwyattii merged commit ffad229 into mrwyattii:pydantify-comms Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrwyattii mrwyattii mrwyattii approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Quentin-Anthony @mrwyattii