Skip to content

add support for Combfilter Waveguide #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add support for Combfilter Waveguide #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
488dc3f
add support for Combfilter Waveguide
Mar 2, 2025
7e71a16
update json due to typo fix
Jul 13, 2025
1c9e1c4
enable hpf/lpf knobs only in combfilter
Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/mruby-zest/example/ZynAnalogFilter.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,18 @@ Group {
end
typ.active = true
end

if(cat.selected == 4)
hpf.active = true
lpf.active = true
else
hpf.active = false
lpf.active = false
end

typ.damage_self
hpf.damage_self
lpf.damage_self
}

function remove_sense() {
Expand Down Expand Up @@ -96,6 +107,11 @@ Group {
path_simp(box.extern + ext)
}
}
Knob {
id: hpf
whenValue: lambda { box.cb};
extern: box.extern + "Phpf"
}
}
ParModuleRow {
NumEntry {
Expand All @@ -121,6 +137,11 @@ Group {
whenValue: lambda { box.cb};
extern: box.extern + "gain"
}
Knob {
id: lpf
whenValue: lambda { box.cb};
extern: box.extern + "Plpf"
}
}

function class_name()
Expand Down
176 changes: 149 additions & 27 deletions src/osc-bridge/schema/test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1263,6 +1263,26 @@
"range" : [0,127],
"default" : "64"

},
{
"path" : "/part[0,15]/kit[0,15]/padpars/GlobalFilter/Phpf",
"shortname": "hpf",
"name" : "Phpf",
"tooltip" : "Waveguide HighPass",
"type" : "i",
"range" : [0,127],
"default" : "0"

},
{
"path" : "/part[0,15]/kit[0,15]/padpars/GlobalFilter/Plpf",
"shortname": "lpf",
"name" : "Plpf",
"tooltip" : "Waveguide LowPass",
"type" : "i",
"range" : [0,127],
"default" : "127"

},
{
"path" : "/part[0,15]/kit[0,15]/padpars/GlobalFilter/Psequencesize",
Expand Down Expand Up @@ -5693,6 +5713,26 @@
"range" : [0,127],
"default" : "64"

},
{
"path" : "/part[0,15]/kit[0,15]/adpars/VoicePar[0,7]/VoiceFilter/Phpf",
"shortname": "hpf",
"name" : "Phpf",
"tooltip" : "Waveguide HighPass",
"type" : "i",
"range" : [0,127],
"default" : "0"

},
{
"path" : "/part[0,15]/kit[0,15]/adpars/VoicePar[0,7]/VoiceFilter/Plpf",
"shortname": "lpf",
"name" : "Plpf",
"tooltip" : "Waveguide LowPass",
"type" : "i",
"range" : [0,127],
"default" : "127"

},
{
"path" : "/part[0,15]/kit[0,15]/adpars/VoicePar[0,7]/VoiceFilter/Psequencesize",
Expand Down Expand Up @@ -7760,6 +7800,26 @@
"range" : [0,127],
"default" : "64"

},
{
"path" : "/part[0,15]/kit[0,15]/adpars/GlobalPar/GlobalFilter/Phpf",
"shortname": "hpf",
"name" : "Phpf",
"tooltip" : "Waveguide HighPass",
"type" : "i",
"range" : [0,127],
"default" : "0"

},
{
"path" : "/part[0,15]/kit[0,15]/adpars/GlobalPar/GlobalFilter/Plpf",
"shortname": "lpf",
"name" : "Plpf",
"tooltip" : "Waveguide LowPass",
"type" : "i",
"range" : [0,127],
"default" : "127"

},
{
"path" : "/part[0,15]/kit[0,15]/adpars/GlobalPar/GlobalFilter/Psequencesize",
Expand Down Expand Up @@ -9326,6 +9386,26 @@
"range" : [0,127],
"default" : "64"

},
{
"path" : "/part[0,15]/kit[0,15]/subpars/GlobalFilter/Phpf",
"shortname": "hpf",
"name" : "Phpf",
"tooltip" : "Waveguide HighPass",
"type" : "i",
"range" : [0,127],
"default" : "0"

},
{
"path" : "/part[0,15]/kit[0,15]/subpars/GlobalFilter/Plpf",
"shortname": "lpf",
"name" : "Plpf",
"tooltip" : "Waveguide LowPass",
"type" : "i",
"range" : [0,127],
"default" : "127"

},
{
"path" : "/part[0,15]/kit[0,15]/subpars/GlobalFilter/Psequencesize",
Expand Down Expand Up @@ -9795,6 +9875,26 @@
"range" : [0,127],
"default" : "64"

},
{
"path" : "/part[0,15]/partefx[0,2]/filterpars/Phpf",
"shortname": "hpf",
"name" : "Phpf",
"tooltip" : "Waveguide HighPass",
"type" : "i",
"range" : [0,127],
"default" : "0"

},
{
"path" : "/part[0,15]/partefx[0,2]/filterpars/Plpf",
"shortname": "lpf",
"name" : "Plpf",
"tooltip" : "Waveguide LowPass",
"type" : "i",
"range" : [0,127],
"default" : "127"

},
{
"path" : "/part[0,15]/partefx[0,2]/filterpars/Psequencesize",
Expand Down Expand Up @@ -11410,9 +11510,7 @@
"tooltip" : "amount of effect",
"scale" : "linear",
"type" : "i",
"range" : [0,127],
"default" : "127"

"range" : [0,127]
},
{
"path" : "/part[0,15]/partefx[0,2]/Sympathetic/Ppanning",
Expand Down Expand Up @@ -11518,9 +11616,7 @@
"tooltip" : "Number of Strings",
"scale" : "linear",
"type" : "i",
"range" : [0,76],
"default" : "12"

"range" : [0,76]
},
{
"path" : "/part[0,15]/partefx[0,2]/Sympathetic/Pbasenote",
Expand All @@ -11529,9 +11625,7 @@
"tooltip" : "Midi Note of Lowest String",
"scale" : "linear",
"type" : "i",
"range" : [0,127],
"default" : "57"

"range" : [0,127]
},
{
"path" : "/part[0,15]/partefx[0,2]/Sympathetic/freqs[0,87]",
Expand Down Expand Up @@ -12423,6 +12517,26 @@
"range" : [0,127],
"default" : "64"

},
{
"path" : "/sysefx[0,3]/filterpars/Phpf",
"shortname": "hpf",
"name" : "Phpf",
"tooltip" : "Waveguide HighPass",
"type" : "i",
"range" : [0,127],
"default" : "0"

},
{
"path" : "/sysefx[0,3]/filterpars/Plpf",
"shortname": "lpf",
"name" : "Plpf",
"tooltip" : "Waveguide LowPass",
"type" : "i",
"range" : [0,127],
"default" : "127"

},
{
"path" : "/sysefx[0,3]/filterpars/Psequencesize",
Expand Down Expand Up @@ -14038,9 +14152,7 @@
"tooltip" : "amount of effect",
"scale" : "linear",
"type" : "i",
"range" : [0,127],
"default" : "127"

"range" : [0,127]
},
{
"path" : "/sysefx[0,3]/Sympathetic/Ppanning",
Expand Down Expand Up @@ -14146,9 +14258,7 @@
"tooltip" : "Number of Strings",
"scale" : "linear",
"type" : "i",
"range" : [0,76],
"default" : "12"

"range" : [0,76]
},
{
"path" : "/sysefx[0,3]/Sympathetic/Pbasenote",
Expand All @@ -14157,9 +14267,7 @@
"tooltip" : "Midi Note of Lowest String",
"scale" : "linear",
"type" : "i",
"range" : [0,127],
"default" : "57"

"range" : [0,127]
},
{
"path" : "/sysefx[0,3]/Sympathetic/freqs[0,87]",
Expand Down Expand Up @@ -14471,6 +14579,26 @@
"range" : [0,127],
"default" : "64"

},
{
"path" : "/insefx[0,7]/filterpars/Phpf",
"shortname": "hpf",
"name" : "Phpf",
"tooltip" : "Waveguide HighPass",
"type" : "i",
"range" : [0,127],
"default" : "0"

},
{
"path" : "/insefx[0,7]/filterpars/Plpf",
"shortname": "lpf",
"name" : "Plpf",
"tooltip" : "Waveguide LowPass",
"type" : "i",
"range" : [0,127],
"default" : "127"

},
{
"path" : "/insefx[0,7]/filterpars/Psequencesize",
Expand Down Expand Up @@ -16086,9 +16214,7 @@
"tooltip" : "amount of effect",
"scale" : "linear",
"type" : "i",
"range" : [0,127],
"default" : "127"

"range" : [0,127]
},
{
"path" : "/insefx[0,7]/Sympathetic/Ppanning",
Expand Down Expand Up @@ -16194,9 +16320,7 @@
"tooltip" : "Number of Strings",
"scale" : "linear",
"type" : "i",
"range" : [0,76],
"default" : "12"

"range" : [0,76]
},
{
"path" : "/insefx[0,7]/Sympathetic/Pbasenote",
Expand All @@ -16205,9 +16329,7 @@
"tooltip" : "Midi Note of Lowest String",
"scale" : "linear",
"type" : "i",
"range" : [0,127],
"default" : "57"

"range" : [0,127]
},
{
"path" : "/insefx[0,7]/Sympathetic/freqs[0,87]",
Expand Down