Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/edit task #17

Merged
merged 7 commits into from
Oct 11, 2020
Merged

Feature/edit task #17

merged 7 commits into from
Oct 11, 2020

Conversation

mrtry
Copy link
Owner

@mrtry mrtry commented Oct 11, 2020

close #7

実装したもの

  • 登録したタスクのタイトルの編集機能
    • descriptionの確認もできる

その他実装したもの

  • ActivityのLifecycleが変わるたびにログを出すWholeActivityDelegateを導入した(デバッグ目的

スクリーンショット

その他

@FragmentScope
class EditTaskDialogFragmentValueHolder
@Inject constructor(fragment: Fragment) {
val task: Task = fragment.requireArguments().getParcelable(KEY_TASK)!!
Copy link
Owner Author

@mrtry mrtry Oct 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fragmentに渡された値をViewModelで共有する用のdata holder

@mrtry mrtry merged commit 0e69247 into develop Oct 11, 2020
@mrtry mrtry deleted the feature/edit-task branch October 11, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToDoのタスク更新機能の実装
1 participant