Skip to content

WIP Add higher order functions#92

Closed
nvander1 wants to merge 1 commit intomasterfrom
higher_order_functions
Closed

WIP Add higher order functions#92
nvander1 wants to merge 1 commit intomasterfrom
higher_order_functions

Conversation

@nvander1
Copy link
Copy Markdown
Collaborator

@nvander1 nvander1 commented May 22, 2019

Based on changes in here apache/spark#24232.

Not ready for merge, I think there are some bugs not caught by the test yet. Need to investigate later.

Also need to test for < spark 2.4, but it should be work since we vendor spark's implementations under org.apache.spark.sql.catalyst.expressions.daria instead of referencing the ones spark provides under org.apache.spark.sql.catalyst.expressions in spark >= 2.4

cc: @manuzhang

@nvander1 nvander1 requested a review from MrPowers May 22, 2019 00:49
@manuzhang
Copy link
Copy Markdown
Collaborator

@nvander1 It might not be worth it if we need to copy the Spark implementations for < 2.4 Spark versions and keep syncing with upstream. It's good enough to have your changes in apache/spark#24232 if they don't end up there.

@nvander1
Copy link
Copy Markdown
Collaborator Author

nvander1 commented May 22, 2019 via email

@nvander1 nvander1 closed this May 31, 2019
@nvander1 nvander1 deleted the higher_order_functions branch May 31, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants