Closed
Conversation
Collaborator
|
@nvander1 It might not be worth it if we need to copy the Spark implementations for < 2.4 Spark versions and keep syncing with upstream. It's good enough to have your changes in apache/spark#24232 if they don't end up there. |
Collaborator
Author
|
Yeah that’s kind of what I’m thinking. I think a good middle ground is to
make just the scala API wrapper for those functions and have hen point to
spark’s implementations of the functions
Le mer. 22 mai 2019 à 05:00, Manu Zhang <notifications@github.com> a écrit :
… @nvander1 <https://github.com/nvander1> It might not be worth it if we
need to copy the Spark implementations for < 2.4 Spark versions and keep
syncing with upstream. It's good enough to have your changes in
apache/spark#24232 <apache/spark#24232> if they
don't end up there.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#92>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACXK4VZXPOUOPLVWKINPN6TPWUDUXANCNFSM4HOPYRMA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on changes in here apache/spark#24232.
Not ready for merge, I think there are some bugs not caught by the test yet. Need to investigate later.
Also need to test for < spark 2.4, but it should be work since we vendor spark's implementations under
org.apache.spark.sql.catalyst.expressions.dariainstead of referencing the ones spark provides underorg.apache.spark.sql.catalyst.expressionsin spark >= 2.4cc: @manuzhang