Skip to content

Bump FluentAssertions from 6.12.1 to 8.8.0 #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bump FluentAssertions from 6.12.1 to 8.8.0 #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageVersion>
<PackageVersion Include="Dawn.Guard" Version="1.12.0" />
<PackageVersion Include="FluentAssertions" Version="6.12.1" />
<PackageVersion Include="FluentAssertions" Version="8.8.0" />
Copy link

@codeant-ai codeant-ai bot Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: If FluentAssertions is a test-only dependency, mark it as private and include explicit asset controls to prevent it being exposed to consuming projects. [best practice]

Severity Level: Minor ⚠️

Suggested change
<PackageVersion Include="FluentAssertions" Version="8.8.0" />
<PackageVersion Include="FluentAssertions" Version="8.8.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageVersion>
Why it matters? ⭐

This repository already uses PackageVersion entries with and for test-only packages (see coverlet.* entries). If FluentAssertions is test-only, adding PrivateAssets prevents it from leaking as a transitive dependency to consuming projects — a useful, low-risk best practice that matches the file's existing patterns. It's not merely cosmetic: it prevents accidental consumption and potential version conflicts downstream.

Prompt for AI Agent 🤖 
<code>This is a comment left during a code review.

**Path:** Directory.Packages.props
**Line:** 19:19
**Comment:**
	*Best Practice: If `FluentAssertions` is a test-only dependency, mark it as private and include explicit asset controls to prevent it being exposed to consuming projects.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.

<PackageVersion Include="FluentAssertions.Analyzers" Version="0.34.1">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
Expand Down
Loading