feat: Support tap to focus without a Preview View #3089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mrousavy
force-pushed
the
feat/tap-to-focus-skia
branch
from
add4f3e to
2064511
Compare
mrousavy
force-pushed
the
feat/tap-to-focus-skia
branch
from
85f8df3 to
11505c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Currently, focusing only works when using the normal Preview View.
When using Skia, there is no Preview View and we cannot focus.
My idea was to move the layer point conversion method to JS, so that we can do it synchronously & instantly - either convert a view point to PreviewView coordinates, or Skia video output stream coordinates.
Unfortunately both iOS and Android do not expose matrixes that allow me to convert
x/ycoordinates myself.You have to use their functions for it, and on Android it only works on the UI Thread (why do you need to dispatch to the UI thread for some number multiplication you ask? I dont know. 🤦♂️)
So now I think the only solution we have is to actually pass a prop to
focuswhich iscoordinateSystem: 'preview' | 'video'... No way around it 🤦♂️Changes
Tested on
Related issues